From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25434 invoked by alias); 28 Jun 2008 17:22:53 -0000 Received: (qmail 25425 invoked by uid 22791); 28 Jun 2008 17:22:52 -0000 X-Spam-Check-By: sourceware.org Received: from mtaout5.012.net.il (HELO mtaout5.012.net.il) (84.95.2.13) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 28 Jun 2008 17:22:30 +0000 Received: from HOME-C4E4A596F7 ([80.230.31.196]) by i_mtaout5.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0K3600K91OY7ME31@i_mtaout5.012.net.il> for gdb-patches@sources.redhat.com; Sat, 28 Jun 2008 20:37:20 +0300 (IDT) Date: Sat, 28 Jun 2008 17:30:00 -0000 From: Eli Zaretskii Subject: Re: [MI non-stop 04/11] Implement --thread and --frame. In-reply-to: <200806282044.14246.vladimir@codesourcery.com> X-012-Sender: halo1@inter.net.il To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Reply-to: Eli Zaretskii Message-id: References: <200806282044.14246.vladimir@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-06/txt/msg00551.txt.bz2 > From: Vladimir Prus > Date: Sat, 28 Jun 2008 20:44:14 +0400 > > > + if (parse->frame != -1 && !parse->thread == -1) > + error ("Cannot specify --frame without --thread"); Why is this error message not in _(), while all the rest are? Btw, do we at all want error messages issued by MI commands translated? MI commands are invoked by a program, so error messages we generate should be understandable by a program, which probably means they should not be translated. > + if (strncmp (chp, "--thread", 8) == 0) Please, let's not use literal constants in this context, let's use sizeof instead. > + parse->frame = strtol (chp, &chp, 10); Do we really want to disallow non-decimal numbers here? What about hex frame numbers?