From: Eli Zaretskii <eliz@gnu.org>
To: Denis PILAT <denis.pilat@st.com>
Cc: gdb-patches@sourceware.org
Subject: Re: '\r' only end-of-line
Date: Tue, 10 Oct 2006 21:34:00 -0000 [thread overview]
Message-ID: <ud58zkg88.fsf@gnu.org> (raw)
In-Reply-To: <452BB767.5000407@st.com> (message from Denis PILAT on Tue, 10 Oct 2006 17:08:23 +0200)
> Date: Tue, 10 Oct 2006 17:08:23 +0200
> From: Denis PILAT <denis.pilat@st.com>
> Cc: Eli Zaretskii <eliz@gnu.org>
>
> As discussed in thread
> http://sources.redhat.com/ml/gdb-patches/2006-10/msg00090.html
> about the TUI that did not display windows source files,
>
> I propose a patch that treats source files where end-of-line are '\r' only.
I think part of your patch is not needed: the Windows port of GDB
should use the LSEEK_NOT_LINEAR branch of the code in
find_source_lines, so the code you are patching doesn't need to
consider the \r\n case.
As for the \r case, don't such files fail in many more places? It
looks like you need to test for \r in every place where we currently
test for \n, or am I missing something?
next prev parent reply other threads:[~2006-10-10 21:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-09 15:25 [TUI] correctly display windows source files Denis PILAT
2006-10-09 18:01 ` Mark Kettenis
2006-10-09 19:28 ` Eli Zaretskii
2006-10-10 13:23 ` Denis PILAT
2006-10-10 15:08 ` '\r' only end-of-line Denis PILAT
2006-10-10 21:34 ` Eli Zaretskii [this message]
2006-10-11 10:08 ` Denis PILAT
2006-10-11 13:33 ` Daniel Jacobowitz
2006-10-11 13:57 ` Andrew STUBBS
2006-10-11 14:01 ` Daniel Jacobowitz
2006-10-11 14:44 ` Andrew STUBBS
2006-10-11 15:05 ` Daniel Jacobowitz
2006-10-11 17:47 ` Eli Zaretskii
2006-10-11 17:36 ` Eli Zaretskii
2006-10-16 8:51 ` Denis PILAT
2006-10-10 21:24 ` [TUI] correctly display windows source files Eli Zaretskii
2006-10-11 8:02 ` Denis PILAT
2006-10-11 8:39 ` Eli Zaretskii
2006-10-11 11:23 ` Frederic RISS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ud58zkg88.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=denis.pilat@st.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox