From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8811 invoked by alias); 10 Oct 2006 21:34:28 -0000 Received: (qmail 8803 invoked by uid 22791); 10 Oct 2006 21:34:27 -0000 X-Spam-Check-By: sourceware.org Received: from romy.inter.net.il (HELO romy.inter.net.il) (192.114.186.66) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 10 Oct 2006 21:34:24 +0000 Received: from HOME-C4E4A596F7 (IGLD-84-228-242-30.inter.net.il [84.228.242.30]) by romy.inter.net.il (MOS 3.7.3-GA) with ESMTP id FZA81177 (AUTH halo1); Tue, 10 Oct 2006 23:34:14 +0200 (IST) Date: Tue, 10 Oct 2006 21:34:00 -0000 Message-Id: From: Eli Zaretskii To: Denis PILAT CC: gdb-patches@sourceware.org In-reply-to: <452BB767.5000407@st.com> (message from Denis PILAT on Tue, 10 Oct 2006 17:08:23 +0200) Subject: Re: '\r' only end-of-line Reply-to: Eli Zaretskii References: <452A6905.1040308@st.com> <452B9EB9.4040709@st.com> <452BB767.5000407@st.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-10/txt/msg00097.txt.bz2 > Date: Tue, 10 Oct 2006 17:08:23 +0200 > From: Denis PILAT > Cc: Eli Zaretskii > > As discussed in thread > http://sources.redhat.com/ml/gdb-patches/2006-10/msg00090.html > about the TUI that did not display windows source files, > > I propose a patch that treats source files where end-of-line are '\r' only. I think part of your patch is not needed: the Windows port of GDB should use the LSEEK_NOT_LINEAR branch of the code in find_source_lines, so the code you are patching doesn't need to consider the \r\n case. As for the \r case, don't such files fail in many more places? It looks like you need to test for \r in every place where we currently test for \n, or am I missing something?