Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Daniel Jacobowitz <drow@false.org>
Cc: denis.pilat@st.com, gdb-patches@sourceware.org
Subject: Re: '\r' only end-of-line
Date: Wed, 11 Oct 2006 17:47:00 -0000	[thread overview]
Message-ID: <u64eqkan7.fsf@gnu.org> (raw)
In-Reply-To: <20061011133254.GA25164@nevyn.them.org> (message from Daniel 	Jacobowitz on Wed, 11 Oct 2006 09:32:54 -0400)

> Date: Wed, 11 Oct 2006 09:32:54 -0400
> From: Daniel Jacobowitz <drow@false.org>
> Cc: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sourceware.org
> 
> As a general position, are we willing to support things written /
> compiled on other hosts?  This includes both line endings and
> pathnames.  I hope the answer is yes, but I don't know.

Well, _my_ answer is a firm YES, and whoever volunteers to make that
happen will get all the support I can provide in my admittedly limited
time.

> debugger got very, very unhappy because there's a filename comparison
> in the dwarf reader; one of the arguments came from the compiler as
> "\foo\bar.h" and the other came in two pieces "\foo" and "bar.h".  GDB
> assembled that as "\foo/bar.h" and FILENAME_CMP returned false.

IMHO, it's fundamentally wrong to compare file names as strings;
FILENAME_CMP is just a band-aid that I introduced as a stop-gap.  We
could (and probably should) do better, especially if situations like
above happen.

Alternatively, we could force GDB to canonicalize all slashes in its
symbol tables, and then FILENAME_CMP will work just fine.  But this is
less reliable, especially in the face of file names that come from
outside GDB, like from the command line etc.

> Would a gdb_filename_cmp with this behavior be OK?

I'd support that, but we need to talk a bit about what it should do,
as there are a few complications.


  parent reply	other threads:[~2006-10-11 17:47 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-09 15:25 [TUI] correctly display windows source files Denis PILAT
2006-10-09 18:01 ` Mark Kettenis
2006-10-09 19:28 ` Eli Zaretskii
2006-10-10 13:23   ` Denis PILAT
2006-10-10 15:08     ` '\r' only end-of-line Denis PILAT
2006-10-10 21:34       ` Eli Zaretskii
2006-10-11 10:08         ` Denis PILAT
2006-10-11 13:33           ` Daniel Jacobowitz
2006-10-11 13:57             ` Andrew STUBBS
2006-10-11 14:01               ` Daniel Jacobowitz
2006-10-11 14:44                 ` Andrew STUBBS
2006-10-11 15:05                   ` Daniel Jacobowitz
2006-10-11 17:47             ` Eli Zaretskii [this message]
2006-10-11 17:36           ` Eli Zaretskii
2006-10-16  8:51             ` Denis PILAT
2006-10-10 21:24     ` [TUI] correctly display windows source files Eli Zaretskii
2006-10-11  8:02       ` Denis PILAT
2006-10-11  8:39         ` Eli Zaretskii
2006-10-11 11:23           ` Frederic RISS

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=u64eqkan7.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=denis.pilat@st.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox