From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28396 invoked by alias); 11 Oct 2006 17:47:14 -0000 Received: (qmail 28387 invoked by uid 22791); 11 Oct 2006 17:47:13 -0000 X-Spam-Check-By: sourceware.org Received: from heller.inter.net.il (HELO heller.inter.net.il) (192.114.186.73) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 11 Oct 2006 17:47:10 +0000 Received: from HOME-C4E4A596F7 (IGLD-80-230-149-41.inter.net.il [80.230.149.41]) by heller.inter.net.il (MOS 3.7.3a-GA) with ESMTP id ARX79298 (AUTH halo1); Wed, 11 Oct 2006 18:47:00 +0200 (IST) Date: Wed, 11 Oct 2006 17:47:00 -0000 Message-Id: From: Eli Zaretskii To: Daniel Jacobowitz CC: denis.pilat@st.com, gdb-patches@sourceware.org In-reply-to: <20061011133254.GA25164@nevyn.them.org> (message from Daniel Jacobowitz on Wed, 11 Oct 2006 09:32:54 -0400) Subject: Re: '\r' only end-of-line Reply-to: Eli Zaretskii References: <452A6905.1040308@st.com> <452B9EB9.4040709@st.com> <452BB767.5000407@st.com> <452CC287.4050401@st.com> <20061011133254.GA25164@nevyn.them.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-10/txt/msg00122.txt.bz2 > Date: Wed, 11 Oct 2006 09:32:54 -0400 > From: Daniel Jacobowitz > Cc: Eli Zaretskii , gdb-patches@sourceware.org > > As a general position, are we willing to support things written / > compiled on other hosts? This includes both line endings and > pathnames. I hope the answer is yes, but I don't know. Well, _my_ answer is a firm YES, and whoever volunteers to make that happen will get all the support I can provide in my admittedly limited time. > debugger got very, very unhappy because there's a filename comparison > in the dwarf reader; one of the arguments came from the compiler as > "\foo\bar.h" and the other came in two pieces "\foo" and "bar.h". GDB > assembled that as "\foo/bar.h" and FILENAME_CMP returned false. IMHO, it's fundamentally wrong to compare file names as strings; FILENAME_CMP is just a band-aid that I introduced as a stop-gap. We could (and probably should) do better, especially if situations like above happen. Alternatively, we could force GDB to canonicalize all slashes in its symbol tables, and then FILENAME_CMP will work just fine. But this is less reliable, especially in the face of file names that come from outside GDB, like from the command line etc. > Would a gdb_filename_cmp with this behavior be OK? I'd support that, but we need to talk a bit about what it should do, as there are a few complications.