From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: denis.pilat@st.com
Cc: gdb-patches@sourceware.org
Subject: Re: [TUI] correctly display windows source files
Date: Mon, 09 Oct 2006 18:01:00 -0000 [thread overview]
Message-ID: <200610091801.k99I1X0q022735@elgar.sibelius.xs4all.nl> (raw)
In-Reply-To: <452A6905.1040308@st.com> (message from Denis PILAT on Mon, 09 Oct 2006 17:21:41 +0200)
> Date: Mon, 09 Oct 2006 17:21:41 +0200
> From: Denis PILAT <denis.pilat@st.com>
>
> Hello,
>
> The TUI displays windows source files with and extra blank line between
> each source line.
> Line number are wrong and changes when source is moved up and down.
>
> This patch fixes this problem and should take the case of MAC OS
> end-of-line into account.
Hmm, I always get nervous when I see ungetc() calls. However, we
already use it in source.c:print_source_line_base() so I guess it is
ok. However, is there any reason why this bit of code is different
from the code in that function?
>
> 2006-10-09 Denis Pilat <denis.pilat@st.com>
>
> * tui-source.c (tui_set_source_content): handle source files that
> contain non unix end-of-line.
>
next prev parent reply other threads:[~2006-10-09 18:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-09 15:25 Denis PILAT
2006-10-09 18:01 ` Mark Kettenis [this message]
2006-10-09 19:28 ` Eli Zaretskii
2006-10-10 13:23 ` Denis PILAT
2006-10-10 15:08 ` '\r' only end-of-line Denis PILAT
2006-10-10 21:34 ` Eli Zaretskii
2006-10-11 10:08 ` Denis PILAT
2006-10-11 13:33 ` Daniel Jacobowitz
2006-10-11 13:57 ` Andrew STUBBS
2006-10-11 14:01 ` Daniel Jacobowitz
2006-10-11 14:44 ` Andrew STUBBS
2006-10-11 15:05 ` Daniel Jacobowitz
2006-10-11 17:47 ` Eli Zaretskii
2006-10-11 17:36 ` Eli Zaretskii
2006-10-16 8:51 ` Denis PILAT
2006-10-10 21:24 ` [TUI] correctly display windows source files Eli Zaretskii
2006-10-11 8:02 ` Denis PILAT
2006-10-11 8:39 ` Eli Zaretskii
2006-10-11 11:23 ` Frederic RISS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200610091801.k99I1X0q022735@elgar.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=denis.pilat@st.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox