From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8255 invoked by alias); 9 Oct 2006 18:01:41 -0000 Received: (qmail 8247 invoked by uid 22791); 9 Oct 2006 18:01:40 -0000 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 09 Oct 2006 18:01:38 +0000 Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.4/8.13.4) with ESMTP id k99I1Ywk025282; Mon, 9 Oct 2006 20:01:34 +0200 (CEST) Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.13.8/8.13.6) with ESMTP id k99I1XaE024330; Mon, 9 Oct 2006 20:01:33 +0200 (CEST) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.13.8/8.13.8/Submit) id k99I1X0q022735; Mon, 9 Oct 2006 20:01:33 +0200 (CEST) Date: Mon, 09 Oct 2006 18:01:00 -0000 Message-Id: <200610091801.k99I1X0q022735@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: denis.pilat@st.com CC: gdb-patches@sourceware.org In-reply-to: <452A6905.1040308@st.com> (message from Denis PILAT on Mon, 09 Oct 2006 17:21:41 +0200) Subject: Re: [TUI] correctly display windows source files References: <452A6905.1040308@st.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-10/txt/msg00077.txt.bz2 > Date: Mon, 09 Oct 2006 17:21:41 +0200 > From: Denis PILAT > > Hello, > > The TUI displays windows source files with and extra blank line between > each source line. > Line number are wrong and changes when source is moved up and down. > > This patch fixes this problem and should take the case of MAC OS > end-of-line into account. Hmm, I always get nervous when I see ungetc() calls. However, we already use it in source.c:print_source_line_base() so I guess it is ok. However, is there any reason why this bit of code is different from the code in that function? > > 2006-10-09 Denis Pilat > > * tui-source.c (tui_set_source_content): handle source files that > contain non unix end-of-line. >