Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: gdb-patches@sources.redhat.com
Subject: Re: Formatting changes to mi-main.c
Date: Sat, 03 Feb 2007 11:37:00 -0000	[thread overview]
Message-ID: <ud54r1nhh.fsf@gnu.org> (raw)
In-Reply-To: <17860.8466.150801.692398@kahikatea.snap.net.nz> (message from 	Nick Roberts on Sat, 3 Feb 2007 18:43:46 +1300)

> From: Nick Roberts <nickrob@snap.net.nz>
> Date: Sat, 3 Feb 2007 18:43:46 +1300
> 
> 2007-02-03  Nick Roberts  <nickrob@snap.net.nz>
> 
> 	* mi/mi-main.c: Numerous formatting changes.

Thanks for taking care of this.

However:

> *** 40,46 ****
>   #include "interps.h"
>   #include "event-loop.h"
>   #include "event-top.h"
> ! #include "gdbcore.h"		/* for write_memory() */
>   #include "value.h"
>   #include "regcache.h"
>   #include "gdb.h"
> --- 40,46 ----
>   #include "interps.h"
>   #include "event-loop.h"
>   #include "event-top.h"
> ! #include "gdbcore.h"		/* For write_memory().  */

Do the GNU coding standards require that even comments that are not
alone on their lines be complete sentences?  I didn't think they do,
and a quick look in standards.texi didn't find such a guideline.
Personally, I like the brief comment style in the original better.

Anyway, the above isn't a complete sentence anyway, even if we begin
it with a capital letter and end it with a period.

Lastly, if, while at that, you find "foo()" being used as a reference
to the function `foo', please change it to `foo'; that part _is_ in
GNU coding standards.

Thanks again.


  reply	other threads:[~2007-02-03 11:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-03  5:44 Nick Roberts
2007-02-03 11:37 ` Eli Zaretskii [this message]
2007-02-03 12:20   ` Mark Kettenis
2007-02-03 15:53     ` Daniel Jacobowitz
2007-02-04  8:26   ` Nick Roberts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ud54r1nhh.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=nickrob@snap.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox