Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: eliz@gnu.org
Cc: nickrob@snap.net.nz, gdb-patches@sources.redhat.com
Subject: Re: Formatting changes to mi-main.c
Date: Sat, 03 Feb 2007 12:20:00 -0000	[thread overview]
Message-ID: <200702031220.l13CKSLd008362@brahms.sibelius.xs4all.nl> (raw)
In-Reply-To: <ud54r1nhh.fsf@gnu.org> (message from Eli Zaretskii on Sat, 03 	Feb 2007 13:36:58 +0200)

> Date: Sat, 03 Feb 2007 13:36:58 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> 
> > From: Nick Roberts <nickrob@snap.net.nz>
> > Date: Sat, 3 Feb 2007 18:43:46 +1300
> > 
> > 2007-02-03  Nick Roberts  <nickrob@snap.net.nz>
> > 
> > 	* mi/mi-main.c: Numerous formatting changes.
> 
> Thanks for taking care of this.
> 
> However:
> 
> > *** 40,46 ****
> >   #include "interps.h"
> >   #include "event-loop.h"
> >   #include "event-top.h"
> > ! #include "gdbcore.h"		/* for write_memory() */
> >   #include "value.h"
> >   #include "regcache.h"
> >   #include "gdb.h"
> > --- 40,46 ----
> >   #include "interps.h"
> >   #include "event-loop.h"
> >   #include "event-top.h"
> > ! #include "gdbcore.h"		/* For write_memory().  */
> 
> Anyway, the above isn't a complete sentence anyway, even if we begin
> it with a capital letter and end it with a period.

The above comment is pointless anyway.  And probably misleading,
because the file probably needs gdbcore.h for things besides
write_memory by now.

I encourage people deleting similar comments, and we really shouln't
add any new comments like that, until something very non-obvious is
going on.  In that case you'd probably need several sentences anyway
to explain things.

Mark


  reply	other threads:[~2007-02-03 12:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-03  5:44 Nick Roberts
2007-02-03 11:37 ` Eli Zaretskii
2007-02-03 12:20   ` Mark Kettenis [this message]
2007-02-03 15:53     ` Daniel Jacobowitz
2007-02-04  8:26   ` Nick Roberts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200702031220.l13CKSLd008362@brahms.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=nickrob@snap.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox