From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11188 invoked by alias); 3 Feb 2007 12:20:48 -0000 Received: (qmail 11178 invoked by uid 22791); 3 Feb 2007 12:20:48 -0000 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO brahms.sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 03 Feb 2007 12:20:43 +0000 Received: from brahms.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by brahms.sibelius.xs4all.nl (8.13.8/8.13.8) with ESMTP id l13CKTtw016772; Sat, 3 Feb 2007 13:20:29 +0100 (CET) Received: (from kettenis@localhost) by brahms.sibelius.xs4all.nl (8.13.8/8.13.8/Submit) id l13CKSLd008362; Sat, 3 Feb 2007 13:20:28 +0100 (CET) Date: Sat, 03 Feb 2007 12:20:00 -0000 Message-Id: <200702031220.l13CKSLd008362@brahms.sibelius.xs4all.nl> From: Mark Kettenis To: eliz@gnu.org CC: nickrob@snap.net.nz, gdb-patches@sources.redhat.com In-reply-to: (message from Eli Zaretskii on Sat, 03 Feb 2007 13:36:58 +0200) Subject: Re: Formatting changes to mi-main.c References: <17860.8466.150801.692398@kahikatea.snap.net.nz> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-02/txt/msg00033.txt.bz2 > Date: Sat, 03 Feb 2007 13:36:58 +0200 > From: Eli Zaretskii > > > From: Nick Roberts > > Date: Sat, 3 Feb 2007 18:43:46 +1300 > > > > 2007-02-03 Nick Roberts > > > > * mi/mi-main.c: Numerous formatting changes. > > Thanks for taking care of this. > > However: > > > *** 40,46 **** > > #include "interps.h" > > #include "event-loop.h" > > #include "event-top.h" > > ! #include "gdbcore.h" /* for write_memory() */ > > #include "value.h" > > #include "regcache.h" > > #include "gdb.h" > > --- 40,46 ---- > > #include "interps.h" > > #include "event-loop.h" > > #include "event-top.h" > > ! #include "gdbcore.h" /* For write_memory(). */ > > Anyway, the above isn't a complete sentence anyway, even if we begin > it with a capital letter and end it with a period. The above comment is pointless anyway. And probably misleading, because the file probably needs gdbcore.h for things besides write_memory by now. I encourage people deleting similar comments, and we really shouln't add any new comments like that, until something very non-obvious is going on. In that case you'd probably need several sentences anyway to explain things. Mark