From: Daniel Jacobowitz <drow@false.org>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: eliz@gnu.org, nickrob@snap.net.nz, gdb-patches@sources.redhat.com
Subject: Re: Formatting changes to mi-main.c
Date: Sat, 03 Feb 2007 15:53:00 -0000 [thread overview]
Message-ID: <20070203155300.GA18355@nevyn.them.org> (raw)
In-Reply-To: <200702031220.l13CKSLd008362@brahms.sibelius.xs4all.nl>
On Sat, Feb 03, 2007 at 01:20:28PM +0100, Mark Kettenis wrote:
> The above comment is pointless anyway. And probably misleading,
> because the file probably needs gdbcore.h for things besides
> write_memory by now.
>
> I encourage people deleting similar comments, and we really shouln't
> add any new comments like that, until something very non-obvious is
> going on. In that case you'd probably need several sentences anyway
> to explain things.
Completely agreed. We have occasional non-obvious header includes
(e.g. ordering problems with system headers), but the rest of the time
it should be obvious: it's a GDB header, we want it for the GDB
functionality it contains, and if the file still compiles with it
removed that usually means we don't need it any more :-)
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-02-03 15:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-03 5:44 Nick Roberts
2007-02-03 11:37 ` Eli Zaretskii
2007-02-03 12:20 ` Mark Kettenis
2007-02-03 15:53 ` Daniel Jacobowitz [this message]
2007-02-04 8:26 ` Nick Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070203155300.GA18355@nevyn.them.org \
--to=drow@false.org \
--cc=eliz@gnu.org \
--cc=gdb-patches@sources.redhat.com \
--cc=mark.kettenis@xs4all.nl \
--cc=nickrob@snap.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox