From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12865 invoked by alias); 3 Feb 2007 15:53:16 -0000 Received: (qmail 12853 invoked by uid 22791); 3 Feb 2007 15:53:15 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Sat, 03 Feb 2007 15:53:11 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1HDNCH-0004o5-PY; Sat, 03 Feb 2007 10:53:01 -0500 Date: Sat, 03 Feb 2007 15:53:00 -0000 From: Daniel Jacobowitz To: Mark Kettenis Cc: eliz@gnu.org, nickrob@snap.net.nz, gdb-patches@sources.redhat.com Subject: Re: Formatting changes to mi-main.c Message-ID: <20070203155300.GA18355@nevyn.them.org> Mail-Followup-To: Mark Kettenis , eliz@gnu.org, nickrob@snap.net.nz, gdb-patches@sources.redhat.com References: <17860.8466.150801.692398@kahikatea.snap.net.nz> <200702031220.l13CKSLd008362@brahms.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200702031220.l13CKSLd008362@brahms.sibelius.xs4all.nl> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-02/txt/msg00034.txt.bz2 On Sat, Feb 03, 2007 at 01:20:28PM +0100, Mark Kettenis wrote: > The above comment is pointless anyway. And probably misleading, > because the file probably needs gdbcore.h for things besides > write_memory by now. > > I encourage people deleting similar comments, and we really shouln't > add any new comments like that, until something very non-obvious is > going on. In that case you'd probably need several sentences anyway > to explain things. Completely agreed. We have occasional non-obvious header includes (e.g. ordering problems with system headers), but the rest of the time it should be obvious: it's a GDB header, we want it for the GDB functionality it contains, and if the file still compiles with it removed that usually means we don't need it any more :-) -- Daniel Jacobowitz CodeSourcery