From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-47512-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 23952 invoked by alias); 3 Feb 2007 11:37:07 -0000
Received: (qmail 23944 invoked by uid 22791); 3 Feb 2007 11:37:06 -0000
X-Spam-Check-By: sourceware.org
Received: from heller.inter.net.il (HELO heller.inter.net.il) (213.8.233.23)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 03 Feb 2007 11:37:01 +0000
Received: from HOME-C4E4A596F7 (IGLD-80-230-204-178.inter.net.il [80.230.204.178]) 	by heller.inter.net.il (MOS 3.7.3a-GA) 	with ESMTP id BUE31283 (AUTH halo1); 	Sat, 3 Feb 2007 13:36:49 +0200 (IST)
Date: Sat, 03 Feb 2007 11:37:00 -0000
Message-Id: <ud54r1nhh.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Nick Roberts <nickrob@snap.net.nz>
CC: gdb-patches@sources.redhat.com
In-reply-to: <17860.8466.150801.692398@kahikatea.snap.net.nz> (message from 	Nick Roberts on Sat, 3 Feb 2007 18:43:46 +1300)
Subject: Re: Formatting changes to mi-main.c
Reply-to: Eli Zaretskii <eliz@gnu.org>
References:  <17860.8466.150801.692398@kahikatea.snap.net.nz>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-02/txt/msg00032.txt.bz2

> From: Nick Roberts <nickrob@snap.net.nz>
> Date: Sat, 3 Feb 2007 18:43:46 +1300
> 
> 2007-02-03  Nick Roberts  <nickrob@snap.net.nz>
> 
> 	* mi/mi-main.c: Numerous formatting changes.

Thanks for taking care of this.

However:

> *** 40,46 ****
>   #include "interps.h"
>   #include "event-loop.h"
>   #include "event-top.h"
> ! #include "gdbcore.h"		/* for write_memory() */
>   #include "value.h"
>   #include "regcache.h"
>   #include "gdb.h"
> --- 40,46 ----
>   #include "interps.h"
>   #include "event-loop.h"
>   #include "event-top.h"
> ! #include "gdbcore.h"		/* For write_memory().  */

Do the GNU coding standards require that even comments that are not
alone on their lines be complete sentences?  I didn't think they do,
and a quick look in standards.texi didn't find such a guideline.
Personally, I like the brief comment style in the original better.

Anyway, the above isn't a complete sentence anyway, even if we begin
it with a capital letter and end it with a period.

Lastly, if, while at that, you find "foo()" being used as a reference
to the function `foo', please change it to `foo'; that part _is_ in
GNU coding standards.

Thanks again.