* [patch] Add x86-64 target to MAINTAINERS, broken @ 2002-02-26 18:44 Andrew Cagney 2002-03-01 22:37 ` Andreas Jaeger 0 siblings, 1 reply; 6+ messages in thread From: Andrew Cagney @ 2002-02-26 18:44 UTC (permalink / raw) To: gdb-patches [-- Attachment #1: Type: text/plain, Size: 414 bytes --] FYI, I've committed the attached. I get the error: In file included from /home/scratch/GDB/src/gdb/x86-64-tdep.c:30: /home/scratch/GDB/src/gdb/x86-64-tdep.h:27: sys/reg.h: No such file or directory gmake[1]: *** [x86-64-tdep.o] Error 1 gmake[1]: Leaving directory `/home/scratch/GDB/X-x86_64-unknown-linux-gnu/gdb' gmake: *** [all-gdb] Error 2 when trying to build an x86_64-linux-gnu target. enjoy, Andrew [-- Attachment #2: diffs --] [-- Type: text/plain, Size: 541 bytes --] 2002-02-26 Andrew Cagney <ac131313@redhat.com> * MAINTAINERS: Add x86-64 target. Index: MAINTAINERS =================================================================== RCS file: /cvs/src/src/gdb/MAINTAINERS,v retrieving revision 1.151 diff -u -r1.151 MAINTAINERS --- MAINTAINERS 2002/02/23 21:44:56 1.151 +++ MAINTAINERS 2002/02/27 02:41:28 @@ -170,6 +170,9 @@ w65 Deleted. + x86-64 (--target=x86_64-linux-gnu broken) + Maintenance only + xstormy16 --target=xstormy16-elf ,-Werror Corinna Vinschen vinschen@redhat.com ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] Add x86-64 target to MAINTAINERS, broken 2002-02-26 18:44 [patch] Add x86-64 target to MAINTAINERS, broken Andrew Cagney @ 2002-03-01 22:37 ` Andreas Jaeger 2002-03-04 3:13 ` Michal Ludvig 0 siblings, 1 reply; 6+ messages in thread From: Andreas Jaeger @ 2002-03-01 22:37 UTC (permalink / raw) To: Andrew Cagney; +Cc: gdb-patches, Michal Ludvig Andrew Cagney <ac131313@cygnus.com> writes: > FYI, > > I've committed the attached. I get the error: > > In file included from /home/scratch/GDB/src/gdb/x86-64-tdep.c:30: > /home/scratch/GDB/src/gdb/x86-64-tdep.h:27: sys/reg.h: No such file or > directory > gmake[1]: *** [x86-64-tdep.o] Error 1 > gmake[1]: Leaving directory > `/home/scratch/GDB/X-x86_64-unknown-linux-gnu/gdb' > gmake: *** [all-gdb] Error 2 > > when trying to build an x86_64-linux-gnu target. I fear you applied a broken patch by Michal. Has this been fixed? Michal, can you test whether the CVS version works now? I'd really like to see x86-64 working - and not as maintaince only. Thanks, Andreas > enjoy, > Andrew > > 2002-02-26 Andrew Cagney <ac131313@redhat.com> > > * MAINTAINERS: Add x86-64 target. > > Index: MAINTAINERS > =================================================================== > RCS file: /cvs/src/src/gdb/MAINTAINERS,v > retrieving revision 1.151 > diff -u -r1.151 MAINTAINERS > --- MAINTAINERS 2002/02/23 21:44:56 1.151 > +++ MAINTAINERS 2002/02/27 02:41:28 > @@ -170,6 +170,9 @@ > > w65 Deleted. > > + x86-64 (--target=x86_64-linux-gnu broken) > + Maintenance only > + > xstormy16 --target=xstormy16-elf ,-Werror > Corinna Vinschen vinschen@redhat.com > -- Andreas Jaeger SuSE Labs aj@suse.de private aj@arthur.inka.de http://www.suse.de/~aj ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] Add x86-64 target to MAINTAINERS, broken 2002-03-01 22:37 ` Andreas Jaeger @ 2002-03-04 3:13 ` Michal Ludvig 2002-03-04 4:35 ` Mark Kettenis 0 siblings, 1 reply; 6+ messages in thread From: Michal Ludvig @ 2002-03-04 3:13 UTC (permalink / raw) To: Andreas Jaeger; +Cc: Andrew Cagney, gdb-patches Andreas Jaeger wrote: > Andrew Cagney <ac131313@cygnus.com> writes: >>In file included from /home/scratch/GDB/src/gdb/x86-64-tdep.c:30: >>/home/scratch/GDB/src/gdb/x86-64-tdep.h:27: sys/reg.h: No such file or >>directory >>gmake[1]: *** [x86-64-tdep.o] Error 1 >>gmake[1]: Leaving directory >>`/home/scratch/GDB/X-x86_64-unknown-linux-gnu/gdb' >>gmake: *** [all-gdb] Error 2 >> >>when trying to build an x86_64-linux-gnu target. >> > > I fear you applied a broken patch by Michal. Has this been fixed? > Michal, can you test whether the CVS version works now? File sys/reg.h comes from x86-64 glibc sources and yes, using my crosscompiler it compiles without problems for --host=x86-64 and --target=x86-64... For --target=x86-64 and --host i686-... it may not work since headers are different. I'll try to solve it. Michal Ludvig -- * SuSE CR, s.r.o * mludvig@suse.cz * +420 2 9654 5373 * http://www.suse.cz ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] Add x86-64 target to MAINTAINERS, broken 2002-03-04 3:13 ` Michal Ludvig @ 2002-03-04 4:35 ` Mark Kettenis 2002-03-04 4:41 ` Michal Ludvig 0 siblings, 1 reply; 6+ messages in thread From: Mark Kettenis @ 2002-03-04 4:35 UTC (permalink / raw) To: Michal Ludvig; +Cc: Andreas Jaeger, Andrew Cagney, gdb-patches Michal Ludvig <mludvig@suse.cz> writes: > Andreas Jaeger wrote: > > Andrew Cagney <ac131313@cygnus.com> writes: > >>In file included from /home/scratch/GDB/src/gdb/x86-64-tdep.c:30: > >>/home/scratch/GDB/src/gdb/x86-64-tdep.h:27: sys/reg.h: No such file or > >>directory > >>gmake[1]: *** [x86-64-tdep.o] Error 1 > >>gmake[1]: Leaving directory > >>`/home/scratch/GDB/X-x86_64-unknown-linux-gnu/gdb' > >>gmake: *** [all-gdb] Error 2 > >> > >>when trying to build an x86_64-linux-gnu target. > >> > > > > I fear you applied a broken patch by Michal. Has this been fixed? > > Michal, can you test whether the CVS version works now? > > File sys/reg.h comes from x86-64 glibc sources and yes, using my > crosscompiler it compiles without problems for --host=x86-64 and > --target=x86-64... x86-64-tdep.h should definitely *not* include <sys/reg.h>, or any target header for that matter. It should be possible to build a GDB that can debug x86-64 stuff on any host. Currently that's not possible since there are problems with dwarfcfi.c, which doesn't compile on a 32-bit host right now, which is a pity since it means I cannot really help you with fixing the x86-64 bits. Anyway, you should really try to test your build with --target=x86-64 on a totally different platform, e.g. *BSD on a sparc. Anyway, I think the attached patch solves the <sys/reg.h> problem. It shouldn't break your x86-64 target, but I'm not entirely sure. Can you test it for me? Mark Index: ChangeLog from Mark Kettenis <kettenis@gnu.org> * x86-64-tdep.h: Do not include <sys/reg.h>. (x86_64_regmap): Remove. Index: x86-64-tdep.h =================================================================== RCS file: /cvs/src/src/gdb/x86-64-tdep.h,v retrieving revision 1.1 diff -u -p -r1.1 x86-64-tdep.h --- x86-64-tdep.h 2001/09/21 12:19:15 1.1 +++ x86-64-tdep.h 2002/03/04 11:34:55 @@ -1,5 +1,5 @@ /* Target-dependent code for GDB, the GNU debugger. - Copyright 2001 + Copyright 2001, 2002 Free Software Foundation, Inc. Contributed by Jiri Smid, SuSE Labs. @@ -24,18 +24,6 @@ #define X86_64_TDEP_H #include "i386-tdep.h" -#include <sys/reg.h> - -/* Mapping between the general-purpose registers in `struct user' - format and GDB's register array layout. */ - -static int x86_64_regmap[] = { - RAX, RDX, RCX, RBX, - RSI, RDI, RBP, RSP, - R8, R9, R10, R11, - R12, R13, R14, R15, - RIP, EFLAGS -}; /* Number of all registers */ #define X86_64_NUM_REGS (51) ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] Add x86-64 target to MAINTAINERS, broken 2002-03-04 4:35 ` Mark Kettenis @ 2002-03-04 4:41 ` Michal Ludvig 2002-03-04 8:40 ` Kevin Buettner 0 siblings, 1 reply; 6+ messages in thread From: Michal Ludvig @ 2002-03-04 4:41 UTC (permalink / raw) To: Mark Kettenis; +Cc: Andreas Jaeger, Andrew Cagney, gdb-patches Mark Kettenis wrote: > Anyway, I think the attached patch solves the <sys/reg.h> problem. It > shouldn't break your x86-64 target, but I'm not entirely sure. Can > you test it for me? And what about including the contents of sys/reg.h directly into x86-64-tdep.h? That should help as well, or not? Michal Ludvig -- * SuSE CR, s.r.o * mludvig@suse.cz * +420 2 9654 5373 * http://www.suse.cz ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] Add x86-64 target to MAINTAINERS, broken 2002-03-04 4:41 ` Michal Ludvig @ 2002-03-04 8:40 ` Kevin Buettner 0 siblings, 0 replies; 6+ messages in thread From: Kevin Buettner @ 2002-03-04 8:40 UTC (permalink / raw) To: Michal Ludvig, Mark Kettenis; +Cc: Andreas Jaeger, Andrew Cagney, gdb-patches On Mar 4, 1:41pm, Michal Ludvig wrote: > Mark Kettenis wrote: > > Anyway, I think the attached patch solves the <sys/reg.h> problem. It > > shouldn't break your x86-64 target, but I'm not entirely sure. Can > > you test it for me? > > And what about including the contents of sys/reg.h directly into > x86-64-tdep.h? That should help as well, or not? You should first ask yourself why <sys/reg.h> is needed in target dependent (but host independent) code. As I understand it, <sys/reg.h> provides the indices by which registers may be found in the data structures used to communicate the register's contents to/from ptrace(). It seems to me that this information is of absolutely no use when building a cross debugger (to x86-64), but is of vital concern in the implementation of a native debugger. Therefore, <sys/reg.h> should included in the appropriate *-nat.c file instead. Kevin ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2002-03-04 16:40 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2002-02-26 18:44 [patch] Add x86-64 target to MAINTAINERS, broken Andrew Cagney 2002-03-01 22:37 ` Andreas Jaeger 2002-03-04 3:13 ` Michal Ludvig 2002-03-04 4:35 ` Mark Kettenis 2002-03-04 4:41 ` Michal Ludvig 2002-03-04 8:40 ` Kevin Buettner
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox