Re: [patch] Add x86-64 target to MAINTAINERS, broken

[Kevin Buettner <kevinb@redhat.com>]

On Mar 4,  1:41pm, Michal Ludvig wrote:

> Mark Kettenis wrote:
> > Anyway, I think the attached patch solves the <sys/reg.h> problem.  It
> > shouldn't break your x86-64 target, but I'm not entirely sure.  Can
> > you test it for me?
> 
> And what about including the contents of sys/reg.h directly into 
> x86-64-tdep.h? That should help as well, or not?

You should first ask yourself why <sys/reg.h> is needed in target
dependent (but host independent) code.  As I understand it,
<sys/reg.h> provides the indices by which registers may be found in
the data structures used to communicate the register's contents to/from
ptrace().  It seems to me that this information is of absolutely no
use when building a cross debugger (to x86-64), but is of vital
concern in the implementation of a native debugger.  Therefore,
<sys/reg.h> should included in the appropriate *-nat.c file instead.

Kevin