From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16751 invoked by alias); 4 Mar 2002 16:40:34 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 16542 invoked from network); 4 Mar 2002 16:40:29 -0000 Received: from unknown (HELO cygnus.com) (205.180.230.5) by sources.redhat.com with SMTP; 4 Mar 2002 16:40:29 -0000 Received: from cse.cygnus.com (cse.cygnus.com [205.180.230.236]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id IAA04620; Mon, 4 Mar 2002 08:40:20 -0800 (PST) Received: (from kev@localhost) by cse.cygnus.com (8.11.6/8.11.6) id g24Ge6T13486; Mon, 4 Mar 2002 09:40:06 -0700 Date: Mon, 04 Mar 2002 08:40:00 -0000 From: Kevin Buettner Message-Id: <1020304164006.ZM13485@localhost.localdomain> In-Reply-To: Michal Ludvig "Re: [patch] Add x86-64 target to MAINTAINERS, broken" (Mar 4, 1:41pm) References: <3C7C4804.4070201@cygnus.com> <3C8356D6.1060202@suse.cz> <86ofi45x3w.fsf@elgar.kettenis.dyndns.org> <3C836B65.2070204@suse.cz> X-Mailer: Z-Mail (4.0.1 13Jan97 Caldera) To: Michal Ludvig , Mark Kettenis Subject: Re: [patch] Add x86-64 target to MAINTAINERS, broken Cc: Andreas Jaeger , Andrew Cagney , gdb-patches@sources.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-03/txt/msg00031.txt.bz2 On Mar 4, 1:41pm, Michal Ludvig wrote: > Mark Kettenis wrote: > > Anyway, I think the attached patch solves the problem. It > > shouldn't break your x86-64 target, but I'm not entirely sure. Can > > you test it for me? > > And what about including the contents of sys/reg.h directly into > x86-64-tdep.h? That should help as well, or not? You should first ask yourself why is needed in target dependent (but host independent) code. As I understand it, provides the indices by which registers may be found in the data structures used to communicate the register's contents to/from ptrace(). It seems to me that this information is of absolutely no use when building a cross debugger (to x86-64), but is of vital concern in the implementation of a native debugger. Therefore, should included in the appropriate *-nat.c file instead. Kevin