Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Daniel Jacobowitz <drow@false.org>
Cc: pedro@codesourcery.com, gdb-patches@sourceware.org
Subject: Re: Patches to build on DJGPP
Date: Sun, 10 Aug 2008 03:19:00 -0000	[thread overview]
Message-ID: <u7iapiml6.fsf@gnu.org> (raw)
In-Reply-To: <20080810000920.GA22119@caradoc.them.org>

> Date: Sat, 9 Aug 2008 20:09:20 -0400
> From: Daniel Jacobowitz <drow@false.org>
> Cc: gdb-patches@sourceware.org
> 
> On Sat, Aug 09, 2008 at 10:41:46PM +0100, Pedro Alves wrote:
> > - "missing sentinel in function calls" warnings:
> > 
> >   NULL is not a pointer in djgpp, it's #define NULL 0.  Recent gcc's
> >   bark on cases like the concat calls I'm fixing, if the last argument
> >   is not a pointer.
> 
> IIRC OpenBSD detects this error too, so I'm not sure why this didn't
> come up before.

IIRC, this problem is an ancient dispute we had with GCC folks.

> >   Include <time.h> in posix-hdep.c, because that's where select is
> >   declared.  (?)
> 
> >From my select man page:
> 
>        /* According to POSIX.1-2001 */
>        #include <sys/select.h>
> 
>        /* According to earlier standards */
>        #include <sys/time.h>
> 
> I'm guessing the time.h - sys/time.h difference is irrelevant, one
> probably includes the other.

In DJGPP, sys/time.h includes time.h, and select is declared in
time.h.  I'm fine with including sys/time.h.


  reply	other threads:[~2008-08-10  3:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-09 21:42 Pedro Alves
2008-08-10  0:10 ` Daniel Jacobowitz
2008-08-10  3:19   ` Eli Zaretskii [this message]
2008-08-10 20:47   ` Pedro Alves
2008-08-10  3:20 ` Eli Zaretskii
2008-08-10  8:33   ` Mark Kettenis
2008-08-10 19:38     ` Eli Zaretskii
2008-08-10 15:39 ` Mark Kettenis
2008-08-10 16:06   ` Daniel Jacobowitz
2008-08-10 17:41   ` Pedro Alves
2008-08-10 17:49     ` Pedro Alves
2008-08-10 18:29       ` Mark Kettenis
2008-08-10 18:44         ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=u7iapiml6.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox