From: Daniel Jacobowitz <drow@false.org>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: pedro@codesourcery.com, gdb-patches@sourceware.org
Subject: Re: Patches to build on DJGPP
Date: Sun, 10 Aug 2008 16:06:00 -0000 [thread overview]
Message-ID: <20080810160500.GA5910@caradoc.them.org> (raw)
In-Reply-To: <200808101536.m7AFadSV028043@brahms.sibelius.xs4all.nl>
On Sun, Aug 10, 2008 at 05:36:39PM +0200, Mark Kettenis wrote:
> > Index: src/gdb/cp-name-parser.y
> > ===================================================================
> > --- src.orig/gdb/cp-name-parser.y 2008-08-09 20:55:32.000000000 +0100
> > +++ src/gdb/cp-name-parser.y 2008-08-09 22:27:04.000000000 +0100
> > @@ -36,6 +36,7 @@ Boston, MA 02110-1301, USA. */
> > #include <unistd.h>
> > #include <string.h>
> >
> > +#include "config.h"
> > #include "safe-ctype.h"
> > #include "libiberty.h"
> > #include "demangle.h"
>
> Hmm, is there a reason not to include "defs.h" here?
It's not a great reason, but yes, there is - this file is otherwise
independent of GDB, because you can link it into a stand-alone test
program. I won't complain if someone adds defs.h, as long as
the test program still links.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-08-10 16:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-09 21:42 Pedro Alves
2008-08-10 0:10 ` Daniel Jacobowitz
2008-08-10 3:19 ` Eli Zaretskii
2008-08-10 20:47 ` Pedro Alves
2008-08-10 3:20 ` Eli Zaretskii
2008-08-10 8:33 ` Mark Kettenis
2008-08-10 19:38 ` Eli Zaretskii
2008-08-10 15:39 ` Mark Kettenis
2008-08-10 16:06 ` Daniel Jacobowitz [this message]
2008-08-10 17:41 ` Pedro Alves
2008-08-10 17:49 ` Pedro Alves
2008-08-10 18:29 ` Mark Kettenis
2008-08-10 18:44 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080810160500.GA5910@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox