Re: Patches to build on DJGPP

[Daniel Jacobowitz <drow@false.org>]

On Sat, Aug 09, 2008 at 10:41:46PM +0100, Pedro Alves wrote:
> - "missing sentinel in function calls" warnings:
> 
>   NULL is not a pointer in djgpp, it's #define NULL 0.  Recent gcc's
>   bark on cases like the concat calls I'm fixing, if the last argument
>   is not a pointer.

IIRC OpenBSD detects this error too, so I'm not sure why this didn't
come up before.

> - cp-name-parse.y
> 
>   There's a call to snprintf in it.  DJGPP gets it from libiberty.
> 
>   I needed to include config.h, so HAVE_DECL_SNPRINTF is defined when
>   libiberty.h is included, which then declares snprintf.
> 
> - gdb_select.h
> 
>   Include sys/types.h to pick up fd_set.
> 
>   Include <time.h> in posix-hdep.c, because that's where select is
>   declared.  (?)

From my select man page:

       /* According to POSIX.1-2001 */
       #include <sys/select.h>

       /* According to earlier standards */
       #include <sys/time.h>

I'm guessing the time.h - sys/time.h difference is irrelevant, one
probably includes the other.

> gdb/
> 2008-08-09  Pedro Alves  <pedro@codesourcery.com>
> 
> 	* buildsym.c (start_subfile): Cast sentinel NULL to void*.
> 	* cp-name-parser.y: Include "config.h".
> 	* posix-hdep.c [__GO32__]: Include time.h.
> 	* xml-tdesc.c (fetch_xml_from_file): Cast sentinel NULL to void*.
> 	* gdb_select.h: Include sys/types.h if available.
> 
> readline/
> 2008-08-09  Pedro Alves  <pedro@codesourcery.com>
> 
> 	* signals.c (rl_set_sighandler): Guard access to SIGWINCH.
> 	* wcwidth.c [__GO32__]: Include wctype.h before wchar.h.
> 
> bfd/
> 2008-08-09  Pedro Alves  <pedro@codesourcery.com>
> 
> 	* archive.c (_bfd_archive_bsd_update_armap_timestamp): Cast stat
> 	st_mtime to long before comparison.

These are all OK.  Could you do three additional things, please?

- You had nice instructions on how to set up DJGPP in your last
message.  Since you've already got them written down, could you put
them on the wiki?  I'm sure someone else will want to do this.

- The readline patches are OK for our import, but if they apply to a
clean upstream tarball of readline, please mail them to bug-bash.

- And last, let the binutils list know I approved the patch to BFD.

-- 
Daniel Jacobowitz
CodeSourcery