From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27929 invoked by alias); 10 Aug 2008 00:10:03 -0000 Received: (qmail 27909 invoked by uid 22791); 10 Aug 2008 00:10:02 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 10 Aug 2008 00:09:23 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 5F71098419; Sun, 10 Aug 2008 00:09:21 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 474729813A; Sun, 10 Aug 2008 00:09:21 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1KRyUq-0005qM-GH; Sat, 09 Aug 2008 20:09:20 -0400 Date: Sun, 10 Aug 2008 00:10:00 -0000 From: Daniel Jacobowitz To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: Patches to build on DJGPP Message-ID: <20080810000920.GA22119@caradoc.them.org> Mail-Followup-To: Pedro Alves , gdb-patches@sourceware.org References: <200808092241.46195.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200808092241.46195.pedro@codesourcery.com> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-08/txt/msg00266.txt.bz2 On Sat, Aug 09, 2008 at 10:41:46PM +0100, Pedro Alves wrote: > - "missing sentinel in function calls" warnings: > > NULL is not a pointer in djgpp, it's #define NULL 0. Recent gcc's > bark on cases like the concat calls I'm fixing, if the last argument > is not a pointer. IIRC OpenBSD detects this error too, so I'm not sure why this didn't come up before. > - cp-name-parse.y > > There's a call to snprintf in it. DJGPP gets it from libiberty. > > I needed to include config.h, so HAVE_DECL_SNPRINTF is defined when > libiberty.h is included, which then declares snprintf. > > - gdb_select.h > > Include sys/types.h to pick up fd_set. > > Include in posix-hdep.c, because that's where select is > declared. (?) >From my select man page: /* According to POSIX.1-2001 */ #include /* According to earlier standards */ #include I'm guessing the time.h - sys/time.h difference is irrelevant, one probably includes the other. > gdb/ > 2008-08-09 Pedro Alves > > * buildsym.c (start_subfile): Cast sentinel NULL to void*. > * cp-name-parser.y: Include "config.h". > * posix-hdep.c [__GO32__]: Include time.h. > * xml-tdesc.c (fetch_xml_from_file): Cast sentinel NULL to void*. > * gdb_select.h: Include sys/types.h if available. > > readline/ > 2008-08-09 Pedro Alves > > * signals.c (rl_set_sighandler): Guard access to SIGWINCH. > * wcwidth.c [__GO32__]: Include wctype.h before wchar.h. > > bfd/ > 2008-08-09 Pedro Alves > > * archive.c (_bfd_archive_bsd_update_armap_timestamp): Cast stat > st_mtime to long before comparison. These are all OK. Could you do three additional things, please? - You had nice instructions on how to set up DJGPP in your last message. Since you've already got them written down, could you put them on the wiki? I'm sure someone else will want to do this. - The readline patches are OK for our import, but if they apply to a clean upstream tarball of readline, please mail them to bug-bash. - And last, let the binutils list know I approved the patch to BFD. -- Daniel Jacobowitz CodeSourcery