From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-57848-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 4363 invoked by alias); 10 Aug 2008 03:19:43 -0000
Received: (qmail 4353 invoked by uid 22791); 10 Aug 2008 03:19:42 -0000
X-Spam-Check-By: sourceware.org
Received: from mtaout7.012.net.il (HELO mtaout7.012.net.il) (84.95.2.19)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 10 Aug 2008 03:19:04 +0000
Received: from HOME-C4E4A596F7 ([84.229.211.50]) by i-mtaout7.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0K5D00FCP7W6U3Q0@i-mtaout7.012.net.il> for gdb-patches@sourceware.org; Sun, 10 Aug 2008 06:19:19 +0300 (IDT)
Date: Sun, 10 Aug 2008 03:19:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: Patches to build on DJGPP
In-reply-to: <20080810000920.GA22119@caradoc.them.org>
X-012-Sender: halo1@inter.net.il
To: Daniel Jacobowitz <drow@false.org>
Cc: pedro@codesourcery.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <u7iapiml6.fsf@gnu.org>
References: <200808092241.46195.pedro@codesourcery.com> <20080810000920.GA22119@caradoc.them.org>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-08/txt/msg00271.txt.bz2

> Date: Sat, 9 Aug 2008 20:09:20 -0400
> From: Daniel Jacobowitz <drow@false.org>
> Cc: gdb-patches@sourceware.org
> 
> On Sat, Aug 09, 2008 at 10:41:46PM +0100, Pedro Alves wrote:
> > - "missing sentinel in function calls" warnings:
> > 
> >   NULL is not a pointer in djgpp, it's #define NULL 0.  Recent gcc's
> >   bark on cases like the concat calls I'm fixing, if the last argument
> >   is not a pointer.
> 
> IIRC OpenBSD detects this error too, so I'm not sure why this didn't
> come up before.

IIRC, this problem is an ancient dispute we had with GCC folks.

> >   Include <time.h> in posix-hdep.c, because that's where select is
> >   declared.  (?)
> 
> >From my select man page:
> 
>        /* According to POSIX.1-2001 */
>        #include <sys/select.h>
> 
>        /* According to earlier standards */
>        #include <sys/time.h>
> 
> I'm guessing the time.h - sys/time.h difference is irrelevant, one
> probably includes the other.

In DJGPP, sys/time.h includes time.h, and select is declared in
time.h.  I'm fine with including sys/time.h.