Re: PATCH: PR corefiles/11481: gcore doesn't work on i386 without SSE

["H.J. Lu" <hjl.tools@gmail.com>]

On Fri, Apr 9, 2010 at 12:15 PM, Mark Kettenis <mark.kettenis@xs4all.nl> wrote:
>> Date: Fri, 9 Apr 2010 09:01:01 -0700
>> From: "H.J. Lu" <hjl.tools@gmail.com>
>>
>> On Fri, Apr 9, 2010 at 8:59 AM, Mark Kettenis <mark.kettenis@xs4all.nl> wrote:
>> >> Date: Fri, 9 Apr 2010 08:50:12 -0700
>> >> From: "H.J. Lu" <hongjiu.lu@intel.com>
>> >>
>> >> Hi,
>> >>
>> >> This patch fixes gcore by not generating core regset sections which
>> >> aren't supported by i386 without SSE.  OK to install?
>> >
>> > Sorry, I think this is the wrong way to fix this.
>> >
>>
>> Any suggestions?
>
> Yup.  This makes sure we always install a list of register notes that
> matches the target description.
>
> 2010-04-09  Mark Kettenis  <kettenis@gnu.org>
>
>        * i386-linux-tdep.c (i386_linux_regset_sections): Remove extended
>        register note sections.
>        (i386_linux_sse_regset_sections, i386_linux_avx_regset_sections):
>        New variables.
>        (i386_linux_init_abi): Install list of supported register note
>        sections that matches the target description.
>

That is nice. We should do the same thing in amd64-linux-tdep.c.

Thanks.


-- 
H.J.