Re: PATCH: PR corefiles/11481: gcore doesn't work on i386 without SSE

[Mark Kettenis <mark.kettenis@xs4all.nl>]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1736 bytes --]

> Date: Fri, 9 Apr 2010 13:43:06 -0700
> From: "H.J. Lu" <hjl.tools@gmail.com>
> 
> On Fri, Apr 9, 2010 at 1:08 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> > On Fri, Apr 9, 2010 at 12:15 PM, Mark Kettenis <mark.kettenis@xs4all.nl> wrote:
> >>> Date: Fri, 9 Apr 2010 09:01:01 -0700
> >>> From: "H.J. Lu" <hjl.tools@gmail.com>
> >>>
> >>> On Fri, Apr 9, 2010 at 8:59 AM, Mark Kettenis <mark.kettenis@xs4all.nl> wrote:
> >>> >> Date: Fri, 9 Apr 2010 08:50:12 -0700
> >>> >> From: "H.J. Lu" <hongjiu.lu@intel.com>
> >>> >>
> >>> >> Hi,
> >>> >>
> >>> >> This patch fixes gcore by not generating core regset sections which
> >>> >> aren't supported by i386 without SSE.  OK to install?
> >>> >
> >>> > Sorry, I think this is the wrong way to fix this.
> >>> >
> >>>
> >>> Any suggestions?
> >>
> >> Yup.  This makes sure we always install a list of register notes that
> >> matches the target description.
> >>
> >> 2010-04-09  Mark Kettenis  <kettenis@gnu.org>
> >>
> >>        * i386-linux-tdep.c (i386_linux_regset_sections): Remove extended
> >>        register note sections.
> >>        (i386_linux_sse_regset_sections, i386_linux_avx_regset_sections):
> >>        New variables.
> >>        (i386_linux_init_abi): Install list of supported register note
> >>        sections that matches the target description.
> >>
> >
> > That is nice. We should do the same thing in amd64-linux-tdep.c.
> >
> 
> My second thought. No need to change amd64-linux-tdep.c.
> We can just add i386_linux_mmx_regset_sections. OK to install?

Why should we do it this way?

I'm not happy with the _mmx suffix to indicate the lack of SSE
registers anyway.  That's something I intend to change once things
have stabilized a bit.