From: "H.J. Lu" <hjl.tools@gmail.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: "H.J. Lu" <hongjiu.lu@intel.com>, GDB <gdb-patches@sourceware.org>
Subject: Re: PATCH: PR corefiles/11481: gcore doesn't work on i386 without SSE
Date: Fri, 09 Apr 2010 16:05:00 -0000 [thread overview]
Message-ID: <l2v6dc9ffc81004090905nd26ba56g905d389d47c18b62@mail.gmail.com> (raw)
In-Reply-To: <20100409160208.GP19194@adacore.com>
On Fri, Apr 9, 2010 at 9:02 AM, Joel Brobecker <brobecker@adacore.com> wrote:
> Mark already answered, but I noticed something that was perhaps worth
> a suggestion:
>
>> + if (i386_linux_regset_sections[i].sect_name == NULL)
>> + internal_error (__FILE__, __LINE__,
>> + _("invalid core regset secion %s"), name);
>
> In this sort of situation (something that should never happen unless
> there is a programming error in GDB), you might prefer the use of
> gdb_assert.
>
I made the change. I am waiting for suggestions before submitting
a new patch.
Thanks.
--
H.J.
prev parent reply other threads:[~2010-04-09 16:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-09 15:50 H.J. Lu
2010-04-09 16:00 ` Mark Kettenis
2010-04-09 16:01 ` H.J. Lu
2010-04-09 19:15 ` Mark Kettenis
2010-04-09 20:08 ` H.J. Lu
2010-04-09 20:43 ` H.J. Lu
2010-04-10 14:49 ` Mark Kettenis
2010-04-10 15:46 ` H.J. Lu
2010-04-13 21:39 ` Mark Kettenis
2010-04-13 21:50 ` Pedro Alves
2010-04-09 16:02 ` Joel Brobecker
2010-04-09 16:05 ` H.J. Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=l2v6dc9ffc81004090905nd26ba56g905d389d47c18b62@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=hongjiu.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox