From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-71936-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 14613 invoked by alias); 9 Apr 2010 16:05:29 -0000
Received: (qmail 14316 invoked by uid 22791); 9 Apr 2010 16:05:24 -0000
X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 	tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SARE_MSGID_LONG45
X-Spam-Check-By: sourceware.org
Received: from mail-vw0-f41.google.com (HELO mail-vw0-f41.google.com) (209.85.212.41)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 09 Apr 2010 16:05:20 +0000
Received: by vws15 with SMTP id 15so295436vws.0         for <gdb-patches@sourceware.org>; Fri, 09 Apr 2010 09:05:18 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.220.44.198 with HTTP; Fri, 9 Apr 2010 09:05:18 -0700 (PDT)
In-Reply-To: <20100409160208.GP19194@adacore.com>
References: <20100409155012.GA19118@intel.com> 	 <20100409160208.GP19194@adacore.com>
Date: Fri, 09 Apr 2010 16:05:00 -0000
Received: by 10.220.124.76 with SMTP id t12mr165091vcr.153.1270829118883; Fri,  	09 Apr 2010 09:05:18 -0700 (PDT)
Message-ID: <l2v6dc9ffc81004090905nd26ba56g905d389d47c18b62@mail.gmail.com>
Subject: Re: PATCH: PR corefiles/11481: gcore doesn't work on i386 without SSE
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: "H.J. Lu" <hongjiu.lu@intel.com>, GDB <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-04/txt/msg00255.txt.bz2

On Fri, Apr 9, 2010 at 9:02 AM, Joel Brobecker <brobecker@adacore.com> wrot=
e:
> Mark already answered, but I noticed something that was perhaps worth
> a suggestion:
>
>> + =A0if (i386_linux_regset_sections[i].sect_name =3D=3D NULL)
>> + =A0 =A0internal_error (__FILE__, __LINE__,
>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 _("invalid core regset secion %s"), na=
me);
>
> In this sort of situation (something that should never happen unless
> there is a programming error in GDB), you might prefer the use of
> gdb_assert.
>

I made the change. I am waiting for suggestions before submitting
a new patch.

Thanks.


--=20
H.J.