From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-71981-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 14059 invoked by alias); 10 Apr 2010 14:49:40 -0000
Received: (qmail 14046 invoked by uid 22791); 10 Apr 2010 14:49:39 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 	tests=BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 10 Apr 2010 14:49:31 +0000
Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) 	by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id o3AEnRxF030020; 	Sat, 10 Apr 2010 16:49:27 +0200 (CEST)
Received: (from kettenis@localhost) 	by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id o3AEnQO3004027; 	Sat, 10 Apr 2010 16:49:26 +0200 (CEST)
Date: Sat, 10 Apr 2010 14:49:00 -0000
Message-Id: <201004101449.o3AEnQO3004027@glazunov.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: hjl.tools@gmail.com
CC: gdb-patches@sourceware.org
In-reply-to: <t2q6dc9ffc81004091343o33b38e61l354f9e4fd3617559@mail.gmail.com> 	(hjl.tools@gmail.com)
Subject: Re: PATCH: PR corefiles/11481: gcore doesn't work on i386 without SSE
References: <20100409155012.GA19118@intel.com> 	 <201004091559.o39FxnQi005865@glazunov.sibelius.xs4all.nl> 	 <o2l6dc9ffc81004090901q538bb961hfee32cd9824516e0@mail.gmail.com> 	 <201004091915.o39JFfFN011160@glazunov.sibelius.xs4all.nl> 	 <t2x6dc9ffc81004091308v63a09220rf211f0b4687eb30@mail.gmail.com> <t2q6dc9ffc81004091343o33b38e61l354f9e4fd3617559@mail.gmail.com>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-04/txt/msg00300.txt.bz2

> Date: Fri, 9 Apr 2010 13:43:06 -0700
> From: "H.J. Lu" <hjl.tools@gmail.com>
> 
> On Fri, Apr 9, 2010 at 1:08 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> > On Fri, Apr 9, 2010 at 12:15 PM, Mark Kettenis <mark.kettenis@xs4all.nl> wrote:
> >>> Date: Fri, 9 Apr 2010 09:01:01 -0700
> >>> From: "H.J. Lu" <hjl.tools@gmail.com>
> >>>
> >>> On Fri, Apr 9, 2010 at 8:59 AM, Mark Kettenis <mark.kettenis@xs4all.nl> wrote:
> >>> >> Date: Fri, 9 Apr 2010 08:50:12 -0700
> >>> >> From: "H.J. Lu" <hongjiu.lu@intel.com>
> >>> >>
> >>> >> Hi,
> >>> >>
> >>> >> This patch fixes gcore by not generating core regset sections which
> >>> >> aren't supported by i386 without SSE.  OK to install?
> >>> >
> >>> > Sorry, I think this is the wrong way to fix this.
> >>> >
> >>>
> >>> Any suggestions?
> >>
> >> Yup.  This makes sure we always install a list of register notes that
> >> matches the target description.
> >>
> >> 2010-04-09  Mark Kettenis  <kettenis@gnu.org>
> >>
> >>        * i386-linux-tdep.c (i386_linux_regset_sections): Remove extended
> >>        register note sections.
> >>        (i386_linux_sse_regset_sections, i386_linux_avx_regset_sections):
> >>        New variables.
> >>        (i386_linux_init_abi): Install list of supported register note
> >>        sections that matches the target description.
> >>
> >
> > That is nice. We should do the same thing in amd64-linux-tdep.c.
> >
> 
> My second thought. No need to change amd64-linux-tdep.c.
> We can just add i386_linux_mmx_regset_sections. OK to install?

Why should we do it this way?

I'm not happy with the _mmx suffix to indicate the lack of SSE
registers anyway.  That's something I intend to change once things
have stabilized a bit.