From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-71962-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 20634 invoked by alias); 9 Apr 2010 20:08:29 -0000
Received: (qmail 20625 invoked by uid 22791); 9 Apr 2010 20:08:28 -0000
X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 	tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SARE_MSGID_LONG45
X-Spam-Check-By: sourceware.org
Received: from mail-vw0-f41.google.com (HELO mail-vw0-f41.google.com) (209.85.212.41)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 09 Apr 2010 20:08:23 +0000
Received: by vws15 with SMTP id 15so416198vws.0         for <gdb-patches@sourceware.org>; Fri, 09 Apr 2010 13:08:22 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.220.44.198 with HTTP; Fri, 9 Apr 2010 13:08:22 -0700 (PDT)
In-Reply-To: <201004091915.o39JFfFN011160@glazunov.sibelius.xs4all.nl>
References: <20100409155012.GA19118@intel.com> 	 <201004091559.o39FxnQi005865@glazunov.sibelius.xs4all.nl> 	 <o2l6dc9ffc81004090901q538bb961hfee32cd9824516e0@mail.gmail.com> 	 <201004091915.o39JFfFN011160@glazunov.sibelius.xs4all.nl>
Date: Fri, 09 Apr 2010 20:08:00 -0000
Received: by 10.220.126.201 with SMTP id d9mr354296vcs.106.1270843702070; Fri,  	09 Apr 2010 13:08:22 -0700 (PDT)
Message-ID: <t2x6dc9ffc81004091308v63a09220rf211f0b4687eb30@mail.gmail.com>
Subject: Re: PATCH: PR corefiles/11481: gcore doesn't work on i386 without SSE
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sourceware.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-04/txt/msg00281.txt.bz2

On Fri, Apr 9, 2010 at 12:15 PM, Mark Kettenis <mark.kettenis@xs4all.nl> wr=
ote:
>> Date: Fri, 9 Apr 2010 09:01:01 -0700
>> From: "H.J. Lu" <hjl.tools@gmail.com>
>>
>> On Fri, Apr 9, 2010 at 8:59 AM, Mark Kettenis <mark.kettenis@xs4all.nl> =
wrote:
>> >> Date: Fri, 9 Apr 2010 08:50:12 -0700
>> >> From: "H.J. Lu" <hongjiu.lu@intel.com>
>> >>
>> >> Hi,
>> >>
>> >> This patch fixes gcore by not generating core regset sections which
>> >> aren't supported by i386 without SSE. =A0OK to install?
>> >
>> > Sorry, I think this is the wrong way to fix this.
>> >
>>
>> Any suggestions?
>
> Yup. =A0This makes sure we always install a list of register notes that
> matches the target description.
>
> 2010-04-09 =A0Mark Kettenis =A0<kettenis@gnu.org>
>
> =A0 =A0 =A0 =A0* i386-linux-tdep.c (i386_linux_regset_sections): Remove e=
xtended
> =A0 =A0 =A0 =A0register note sections.
> =A0 =A0 =A0 =A0(i386_linux_sse_regset_sections, i386_linux_avx_regset_sec=
tions):
> =A0 =A0 =A0 =A0New variables.
> =A0 =A0 =A0 =A0(i386_linux_init_abi): Install list of supported register =
note
> =A0 =A0 =A0 =A0sections that matches the target description.
>

That is nice. We should do the same thing in amd64-linux-tdep.c.

Thanks.


--=20
H.J.