* [RFA] bsd-kvm.c: open read-write when write_files is set.
@ 2006-07-01 16:37 Nathan J. Williams
2006-07-01 17:06 ` Mark Kettenis
0 siblings, 1 reply; 2+ messages in thread
From: Nathan J. Williams @ 2006-07-01 16:37 UTC (permalink / raw)
To: gdb-patches
This should be a pretty minor approval; it struck me as a bit shy of
"obvious", though.
- Nathan
2006-07-01 Nathan J. Williams <nathanw@wasabisystems.com>
* bsd-kvm.c (bsd_kvm_open): Open the KVM interface read-write if
write_files is set.
Index: bsd-kvm.c
===================================================================
RCS file: /cvs/src/src/gdb/bsd-kvm.c,v
retrieving revision 1.16
diff -u -r1.16 bsd-kvm.c
--- bsd-kvm.c 17 Dec 2005 22:33:59 -0000 1.16
+++ bsd-kvm.c 1 Jul 2006 16:37:24 -0000
@@ -81,7 +81,8 @@
}
execfile = get_exec_file (0);
- temp_kd = kvm_openfiles (execfile, filename, NULL, O_RDONLY, errbuf);
+ temp_kd = kvm_openfiles (execfile, filename, NULL,
+ write_files ? O_RDWR : O_RDONLY, errbuf);
if (temp_kd == NULL)
error (("%s"), errbuf);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [RFA] bsd-kvm.c: open read-write when write_files is set.
2006-07-01 16:37 [RFA] bsd-kvm.c: open read-write when write_files is set Nathan J. Williams
@ 2006-07-01 17:06 ` Mark Kettenis
0 siblings, 0 replies; 2+ messages in thread
From: Mark Kettenis @ 2006-07-01 17:06 UTC (permalink / raw)
To: nathanw; +Cc: gdb-patches
> From: "Nathan J. Williams" <nathanw@wasabisystems.com>
> Date: 01 Jul 2006 12:37:45 -0400
>
> This should be a pretty minor approval; it struck me as a bit shy of
> "obvious", though.
Looks sane to me. Suppose this allows you to do very scary things ;-).
>
> 2006-07-01 Nathan J. Williams <nathanw@wasabisystems.com>
>
> * bsd-kvm.c (bsd_kvm_open): Open the KVM interface read-write if
> write_files is set.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-07-01 17:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-07-01 16:37 [RFA] bsd-kvm.c: open read-write when write_files is set Nathan J. Williams
2006-07-01 17:06 ` Mark Kettenis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox