From: "Nathan J. Williams" <nathanw@wasabisystems.com>
To: gdb-patches@sources.redhat.com
Subject: [RFA] bsd-kvm.c: open read-write when write_files is set.
Date: Sat, 01 Jul 2006 16:37:00 -0000 [thread overview]
Message-ID: <mtuac7t46xy.fsf@contents-vnder-pressvre.mit.edu> (raw)
This should be a pretty minor approval; it struck me as a bit shy of
"obvious", though.
- Nathan
2006-07-01 Nathan J. Williams <nathanw@wasabisystems.com>
* bsd-kvm.c (bsd_kvm_open): Open the KVM interface read-write if
write_files is set.
Index: bsd-kvm.c
===================================================================
RCS file: /cvs/src/src/gdb/bsd-kvm.c,v
retrieving revision 1.16
diff -u -r1.16 bsd-kvm.c
--- bsd-kvm.c 17 Dec 2005 22:33:59 -0000 1.16
+++ bsd-kvm.c 1 Jul 2006 16:37:24 -0000
@@ -81,7 +81,8 @@
}
execfile = get_exec_file (0);
- temp_kd = kvm_openfiles (execfile, filename, NULL, O_RDONLY, errbuf);
+ temp_kd = kvm_openfiles (execfile, filename, NULL,
+ write_files ? O_RDWR : O_RDONLY, errbuf);
if (temp_kd == NULL)
error (("%s"), errbuf);
next reply other threads:[~2006-07-01 16:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-01 16:37 Nathan J. Williams [this message]
2006-07-01 17:06 ` Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mtuac7t46xy.fsf@contents-vnder-pressvre.mit.edu \
--to=nathanw@wasabisystems.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox