From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29027 invoked by alias); 1 Jul 2006 16:37:53 -0000 Received: (qmail 29016 invoked by uid 22791); 1 Jul 2006 16:37:53 -0000 X-Spam-Check-By: sourceware.org Received: from BISCAYNE-ONE-STATION.MIT.EDU (HELO biscayne-one-station.mit.edu) (18.7.7.80) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 01 Jul 2006 16:37:51 +0000 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) by biscayne-one-station.mit.edu (8.13.6/8.9.2) with ESMTP id k61GbmON027181 for ; Sat, 1 Jul 2006 12:37:48 -0400 (EDT) Received: from contents-vnder-pressvre.mit.edu (CONTENTS-VNDER-PRESSVRE.MIT.EDU [18.7.16.67]) (authenticated bits=56) (User authenticated as nathanw@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id k61Gbj99011336 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Sat, 1 Jul 2006 12:37:46 -0400 (EDT) Received: (from nathanw@localhost) by contents-vnder-pressvre.mit.edu (8.12.9.20060308) id k61GbjQs004850; Sat, 1 Jul 2006 12:37:45 -0400 (EDT) To: gdb-patches@sources.redhat.com Subject: [RFA] bsd-kvm.c: open read-write when write_files is set. From: "Nathan J. Williams" Date: Sat, 01 Jul 2006 16:37:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: 0 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-07/txt/msg00001.txt.bz2 This should be a pretty minor approval; it struck me as a bit shy of "obvious", though. - Nathan 2006-07-01 Nathan J. Williams * bsd-kvm.c (bsd_kvm_open): Open the KVM interface read-write if write_files is set. Index: bsd-kvm.c =================================================================== RCS file: /cvs/src/src/gdb/bsd-kvm.c,v retrieving revision 1.16 diff -u -r1.16 bsd-kvm.c --- bsd-kvm.c 17 Dec 2005 22:33:59 -0000 1.16 +++ bsd-kvm.c 1 Jul 2006 16:37:24 -0000 @@ -81,7 +81,8 @@ } execfile = get_exec_file (0); - temp_kd = kvm_openfiles (execfile, filename, NULL, O_RDONLY, errbuf); + temp_kd = kvm_openfiles (execfile, filename, NULL, + write_files ? O_RDWR : O_RDONLY, errbuf); if (temp_kd == NULL) error (("%s"), errbuf);