Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Palmer Dabbelt <palmer@sifive.com>
To: andrew.burgess@embecosm.com
Cc: gdb-patches@sourceware.org, Jim Wilson <jimw@sifive.com>,
	 andrew.burgess@embecosm.com
Subject: Re: [PATCH 0/4] RISCV Non-DWARF stack unwinding
Date: Wed, 29 Aug 2018 23:36:00 -0000	[thread overview]
Message-ID: <mhng-c2baf670-123e-45bb-a6cd-5194b6c24cf6@palmer-si-x1c4> (raw)
In-Reply-To: <cover.1535560591.git.andrew.burgess@embecosm.com>

On Wed, 29 Aug 2018 09:40:50 PDT (-0700), andrew.burgess@embecosm.com wrote:
> A series of patches providing non-DWARF stack unwinding on RISC-V.
> Tested on a set of targetes including with and without compressed, and
> FP, and on 32 and 64 bit.
>
> Patch #3 touches generic code and so will need global maintainer
> review before I can commit.
>
> Review and feedback is welcome for all of the other patches too.

I have a few minor comments, but nothing that should block merging the patches 
on my end.  No idea about the global stuff, though, as I'm far from a GDB 
expert.

Thanks!

>
> Thanks,
> Andrew
>
> ---
>
> Andrew Burgess (4):
>   gdb/riscv: remove extra caching of misa register
>   gdb/riscv: Extend instruction decode to cover more instructions
>   gdb: Extend the trad-frame API
>   gdb/riscv: Provide non-DWARF stack unwinder
>
>  gdb/ChangeLog    |  42 +++++++
>  gdb/riscv-tdep.c | 361 +++++++++++++++++++++++++++++++++----------------------
>  gdb/riscv-tdep.h |   2 +
>  gdb/trad-frame.c |  21 +++-
>  gdb/trad-frame.h |   8 ++
>  5 files changed, 287 insertions(+), 147 deletions(-)


      parent reply	other threads:[~2018-08-29 23:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-29 16:41 Andrew Burgess
2018-08-29 16:41 ` [PATCH 2/4] gdb/riscv: Extend instruction decode to cover more instructions Andrew Burgess
2018-08-29 22:05   ` Jim Wilson
2018-08-29 23:10   ` Palmer Dabbelt
2018-08-29 16:41 ` [PATCH 4/4] gdb/riscv: Provide non-DWARF stack unwinder Andrew Burgess
2018-08-29 23:36   ` Palmer Dabbelt
2018-08-29 16:41 ` [PATCH 3/4] gdb: Extend the trad-frame API Andrew Burgess
2018-08-31 15:03   ` Tom Tromey
2018-08-29 16:41 ` [PATCH 1/4] gdb/riscv: remove extra caching of misa register Andrew Burgess
2018-08-29 23:10   ` Palmer Dabbelt
2018-08-29 23:36 ` Palmer Dabbelt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mhng-c2baf670-123e-45bb-a6cd-5194b6c24cf6@palmer-si-x1c4 \
    --to=palmer@sifive.com \
    --cc=andrew.burgess@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jimw@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox