From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org, jimw@sifive.com, palmer@sifive.com
Subject: Re: [PATCH 3/4] gdb: Extend the trad-frame API
Date: Fri, 31 Aug 2018 15:03:00 -0000 [thread overview]
Message-ID: <87a7p21svy.fsf@tromey.com> (raw)
In-Reply-To: <e3d577115aafef1b3cc48e649b792566a95eeae7.1535560591.git.andrew.burgess@embecosm.com> (Andrew Burgess's message of "Wed, 29 Aug 2018 17:40:53 +0100")
>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:
Andrew> Adds two new functions to the trad-frame API and update the internals
Andrew> of trad-frame to use the new functions. These functions will be used
Andrew> in later commits.
Andrew> gdb/ChangeLog:
Andrew> * trad-frame.h (trad_frame_set_realreg): Declare.
Andrew> (trad_frame_set_addr): Declare.
Andrew> * trad-frame.c (trad_frame_set_realreg): Define new function.
Andrew> (trad_frame_set_addr): Define new function.
Andrew> (trad_frame_set_reg_realreg): Use new function.
Andrew> (trad_frame_set_reg_addr): Use new function.
IIUC this is just exposing a bit more of trad frame, so that you can
manipulate the information without having a frame cache.
This seems reasonable enough. This is ok.
I suppose another approach would have been to just keep a trad frame
cache as a member of your new object. But there's nothing wrong with
your chosen approach either, IMO.
Tom
next prev parent reply other threads:[~2018-08-31 15:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-29 16:41 [PATCH 0/4] RISCV Non-DWARF stack unwinding Andrew Burgess
2018-08-29 16:41 ` [PATCH 1/4] gdb/riscv: remove extra caching of misa register Andrew Burgess
2018-08-29 23:10 ` Palmer Dabbelt
2018-08-29 16:41 ` [PATCH 2/4] gdb/riscv: Extend instruction decode to cover more instructions Andrew Burgess
2018-08-29 22:05 ` Jim Wilson
2018-08-29 23:10 ` Palmer Dabbelt
2018-08-29 16:41 ` [PATCH 3/4] gdb: Extend the trad-frame API Andrew Burgess
2018-08-31 15:03 ` Tom Tromey [this message]
2018-08-29 16:41 ` [PATCH 4/4] gdb/riscv: Provide non-DWARF stack unwinder Andrew Burgess
2018-08-29 23:36 ` Palmer Dabbelt
2018-08-29 23:36 ` [PATCH 0/4] RISCV Non-DWARF stack unwinding Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7p21svy.fsf@tromey.com \
--to=tom@tromey.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=jimw@sifive.com \
--cc=palmer@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox