From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27564 invoked by alias); 31 Aug 2018 15:03:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27522 invoked by uid 89); 31 Aug 2018 15:03:02 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=manipulate X-HELO: gateway24.websitewelcome.com Received: from gateway24.websitewelcome.com (HELO gateway24.websitewelcome.com) (192.185.50.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 31 Aug 2018 15:03:00 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 783294128 for ; Fri, 31 Aug 2018 10:02:59 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id vkwMfMnN6bXuJvkwefhlom; Fri, 31 Aug 2018 10:02:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=YOFF0hN3WaJvQNydjSf5uPtQdTTWbmVRlNcQq/v3WP0=; b=EUU2KGckgAmFzyXAzjV1KyDE2b gyiMTzzzPQ2K5u/BKsxGXxlqDI77n0kw4vrOtDivm+WGdH+edw+yIaZeiMol661OZf76+1ehsCskk s6d4GYscukrfjGJpbS59XNMk0; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:58140 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fvkwM-000FCi-2P; Fri, 31 Aug 2018 10:02:26 -0500 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org, jimw@sifive.com, palmer@sifive.com Subject: Re: [PATCH 3/4] gdb: Extend the trad-frame API References: Date: Fri, 31 Aug 2018 15:03:00 -0000 In-Reply-To: (Andrew Burgess's message of "Wed, 29 Aug 2018 17:40:53 +0100") Message-ID: <87a7p21svy.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-08/txt/msg00861.txt.bz2 >>>>> "Andrew" == Andrew Burgess writes: Andrew> Adds two new functions to the trad-frame API and update the internals Andrew> of trad-frame to use the new functions. These functions will be used Andrew> in later commits. Andrew> gdb/ChangeLog: Andrew> * trad-frame.h (trad_frame_set_realreg): Declare. Andrew> (trad_frame_set_addr): Declare. Andrew> * trad-frame.c (trad_frame_set_realreg): Define new function. Andrew> (trad_frame_set_addr): Define new function. Andrew> (trad_frame_set_reg_realreg): Use new function. Andrew> (trad_frame_set_reg_addr): Use new function. IIUC this is just exposing a bit more of trad frame, so that you can manipulate the information without having a frame cache. This seems reasonable enough. This is ok. I suppose another approach would have been to just keep a trad frame cache as a member of your new object. But there's nothing wrong with your chosen approach either, IMO. Tom