* [commit/regression] Fix remote-sim.c regression on PPC64
@ 2012-08-22 21:39 Sergio Durigan Junior
2012-08-23 1:59 ` Tom Tromey
0 siblings, 1 reply; 2+ messages in thread
From: Sergio Durigan Junior @ 2012-08-22 21:39 UTC (permalink / raw)
To: GDB Patches
Hello,
Thanks to Edjunior this regression came to my notice on PPC64
(coincidentally I was also running some tests on a similiar machine).
The regression was introduced by Tom's commit:
http://sourceware.org/ml/gdb-cvs/2012-08/msg00160.html
The fix was easy: pass NULL as the first argument of
`register_inferior_data_with_cleanup'.
Here is the commit.
--
Sergio
Index: gdb/ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/ChangeLog,v
retrieving revision 1.14622
diff -u -p -r1.14622 ChangeLog
--- gdb/ChangeLog 22 Aug 2012 21:04:52 -0000 1.14622
+++ gdb/ChangeLog 22 Aug 2012 21:30:16 -0000
@@ -1,3 +1,8 @@
+2012-08-22 Sergio Durigan Junior <sergiodj@redhat.com>
+
+ * remote-sim.c (_initialize_remote_sim): Pass NULL argument to
+ `register_inferior_data_with_cleanup', fixing regression on PowerPC64.
+
2012-08-22 Khoo Yit Phang <khooyp@cs.umd.edu>
Enable readline in Python in a GDB-specific way and block the
Index: gdb/remote-sim.c
===================================================================
RCS file: /cvs/src/src/gdb/remote-sim.c,v
retrieving revision 1.112
diff -u -p -r1.112 remote-sim.c
--- gdb/remote-sim.c 22 Aug 2012 17:48:52 -0000 1.112
+++ gdb/remote-sim.c 22 Aug 2012 21:30:16 -0000
@@ -1322,5 +1322,5 @@ _initialize_remote_sim (void)
set_cmd_completer (c, sim_command_completer);
sim_inferior_data_key
- = register_inferior_data_with_cleanup (sim_inferior_data_cleanup);
+ = register_inferior_data_with_cleanup (NULL, sim_inferior_data_cleanup);
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [commit/regression] Fix remote-sim.c regression on PPC64
2012-08-22 21:39 [commit/regression] Fix remote-sim.c regression on PPC64 Sergio Durigan Junior
@ 2012-08-23 1:59 ` Tom Tromey
0 siblings, 0 replies; 2+ messages in thread
From: Tom Tromey @ 2012-08-23 1:59 UTC (permalink / raw)
To: Sergio Durigan Junior; +Cc: GDB Patches
>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
Sergio> The fix was easy: pass NULL as the first argument of
Sergio> `register_inferior_data_with_cleanup'.
Thanks Sergio. I'm sorry for the breakage.
Tom
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-08-23 1:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-08-22 21:39 [commit/regression] Fix remote-sim.c regression on PPC64 Sergio Durigan Junior
2012-08-23 1:59 ` Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox