From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25681 invoked by alias); 22 Aug 2012 21:39:11 -0000 Received: (qmail 25606 invoked by uid 22791); 22 Aug 2012 21:39:10 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 22 Aug 2012 21:38:53 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7MLcrIn020733 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 22 Aug 2012 17:38:53 -0400 Received: from psique (ovpn-113-26.phx2.redhat.com [10.3.113.26]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q7MLcoL9018776 for ; Wed, 22 Aug 2012 17:38:52 -0400 From: Sergio Durigan Junior To: GDB Patches Subject: [commit/regression] Fix remote-sim.c regression on PPC64 X-URL: http://www.redhat.com Date: Wed, 22 Aug 2012 21:39:00 -0000 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00639.txt.bz2 Hello, Thanks to Edjunior this regression came to my notice on PPC64 (coincidentally I was also running some tests on a similiar machine). The regression was introduced by Tom's commit: http://sourceware.org/ml/gdb-cvs/2012-08/msg00160.html The fix was easy: pass NULL as the first argument of `register_inferior_data_with_cleanup'. Here is the commit. -- Sergio Index: gdb/ChangeLog =================================================================== RCS file: /cvs/src/src/gdb/ChangeLog,v retrieving revision 1.14622 diff -u -p -r1.14622 ChangeLog --- gdb/ChangeLog 22 Aug 2012 21:04:52 -0000 1.14622 +++ gdb/ChangeLog 22 Aug 2012 21:30:16 -0000 @@ -1,3 +1,8 @@ +2012-08-22 Sergio Durigan Junior + + * remote-sim.c (_initialize_remote_sim): Pass NULL argument to + `register_inferior_data_with_cleanup', fixing regression on PowerPC64. + 2012-08-22 Khoo Yit Phang Enable readline in Python in a GDB-specific way and block the Index: gdb/remote-sim.c =================================================================== RCS file: /cvs/src/src/gdb/remote-sim.c,v retrieving revision 1.112 diff -u -p -r1.112 remote-sim.c --- gdb/remote-sim.c 22 Aug 2012 17:48:52 -0000 1.112 +++ gdb/remote-sim.c 22 Aug 2012 21:30:16 -0000 @@ -1322,5 +1322,5 @@ _initialize_remote_sim (void) set_cmd_completer (c, sim_command_completer); sim_inferior_data_key - = register_inferior_data_with_cleanup (sim_inferior_data_cleanup); + = register_inferior_data_with_cleanup (NULL, sim_inferior_data_cleanup); }