Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Sergio Durigan Junior <sergiodj@redhat.com>
To: GDB Patches <gdb-patches@sourceware.org>
Subject: [commit/regression] Fix remote-sim.c regression on PPC64
Date: Wed, 22 Aug 2012 21:39:00 -0000	[thread overview]
Message-ID: <m3zk5mli8l.fsf@redhat.com> (raw)

Hello,

Thanks to Edjunior this regression came to my notice on PPC64
(coincidentally I was also running some tests on a similiar machine).
The regression was introduced by Tom's commit:

    http://sourceware.org/ml/gdb-cvs/2012-08/msg00160.html

The fix was easy: pass NULL as the first argument of
`register_inferior_data_with_cleanup'.

Here is the commit.

-- 
Sergio

Index: gdb/ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/ChangeLog,v
retrieving revision 1.14622
diff -u -p -r1.14622 ChangeLog
--- gdb/ChangeLog	22 Aug 2012 21:04:52 -0000	1.14622
+++ gdb/ChangeLog	22 Aug 2012 21:30:16 -0000
@@ -1,3 +1,8 @@
+2012-08-22  Sergio Durigan Junior  <sergiodj@redhat.com>
+
+	* remote-sim.c (_initialize_remote_sim): Pass NULL argument to
+	`register_inferior_data_with_cleanup', fixing regression on PowerPC64.
+
 2012-08-22  Khoo Yit Phang <khooyp@cs.umd.edu>
 
 	Enable readline in Python in a GDB-specific way and block the
Index: gdb/remote-sim.c
===================================================================
RCS file: /cvs/src/src/gdb/remote-sim.c,v
retrieving revision 1.112
diff -u -p -r1.112 remote-sim.c
--- gdb/remote-sim.c	22 Aug 2012 17:48:52 -0000	1.112
+++ gdb/remote-sim.c	22 Aug 2012 21:30:16 -0000
@@ -1322,5 +1322,5 @@ _initialize_remote_sim (void)
   set_cmd_completer (c, sim_command_completer);
 
   sim_inferior_data_key
-    = register_inferior_data_with_cleanup (sim_inferior_data_cleanup);
+    = register_inferior_data_with_cleanup (NULL, sim_inferior_data_cleanup);
 }


             reply	other threads:[~2012-08-22 21:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-22 21:39 Sergio Durigan Junior [this message]
2012-08-23  1:59 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3zk5mli8l.fsf@redhat.com \
    --to=sergiodj@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox