From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFA: fix address in call to val_print
Date: Mon, 24 Nov 2008 01:41:00 -0000 [thread overview]
Message-ID: <m3y6zb8wtr.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20081122175354.GF4318@adacore.com> (Joel Brobecker's message of "Sat\, 22 Nov 2008 09\:53\:54 -0800")
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
>> Ok, I will hold off on this patch until I can make a test case.
Joel> No no, don't, that's not what I meant - the patch looked good so let's
Joel> put it in now. If you had a testcase, then let's have it now rather than
Joel> later, even if it already passed before you applied the patch. If not,
Joel> oh well. Sorry, I realize I'm not always clear when I express myself.
Sorry, I was too brief.
My reasoning was that I do not know whether it is easy to make a test
case or not. I would have to look into it.
IMO, if it is possible, it makes the most sense to do this before
committing the patch. Otherwise, I will have to undo the patch to
test it, which is a pain (not so bad in this instance, but in
general).
Tom
next prev parent reply other threads:[~2008-11-22 18:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-21 16:22 Tom Tromey
2008-11-22 18:16 ` Joel Brobecker
2008-11-23 21:15 ` Tom Tromey
2008-11-23 23:06 ` Joel Brobecker
2008-11-24 1:41 ` Tom Tromey [this message]
2008-11-24 2:30 ` Joel Brobecker
2008-11-24 3:09 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3y6zb8wtr.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox