From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFA: fix address in call to val_print
Date: Sat, 22 Nov 2008 18:16:00 -0000 [thread overview]
Message-ID: <20081122051123.GC4318@adacore.com> (raw)
In-Reply-To: <m33ahmexvp.fsf@fleche.redhat.com>
> 2008-11-20 Paul Pluzhnikov <ppluzhnikov@google.com>
>
> * valprint.c (val_print_array_elements): Pass correct
> element address to val_print.
Sure! It looks pretty clearly correct to me as well.
I'm wondering about the testcase. As I understand it, it wouldn't cause
any problem with the current FSF version of GDB. But if it's easy to
create one, then I think it'd still be a useful test to have, just to
make sure it doesn't regress in the future.
--
Joel
next prev parent reply other threads:[~2008-11-22 5:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-21 16:22 Tom Tromey
2008-11-22 18:16 ` Joel Brobecker [this message]
2008-11-23 21:15 ` Tom Tromey
2008-11-23 23:06 ` Joel Brobecker
2008-11-24 1:41 ` Tom Tromey
2008-11-24 2:30 ` Joel Brobecker
2008-11-24 3:09 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081122051123.GC4318@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox