From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFA: fix address in call to val_print
Date: Mon, 24 Nov 2008 02:30:00 -0000 [thread overview]
Message-ID: <20081122182132.GH4318@adacore.com> (raw)
In-Reply-To: <m3y6zb8wtr.fsf@fleche.redhat.com>
> My reasoning was that I do not know whether it is easy to make a test
> case or not. I would have to look into it.
Aha, I see.
What I understood from your original patch was that Paul encountered
an actual problem in the Archer GDB, which prompted the patch. The
scenario in which Archer GDB fails before the patch and passes after
was all that I was wondering about. If we can put that example and
stuff it in a testcase now, then let's do it if you have the time.
If it depends on some functionality that's still only in the Archer
repo, then let's defer that until that piece of functionaly is in
the FSF repo.
In the meantime, the code patch is OK to go in (unless you'd prefer
to hold off on it, but I would imagine that the fewer local changes
in the Archer repo, the better).
--
Joel
next prev parent reply other threads:[~2008-11-22 18:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-21 16:22 Tom Tromey
2008-11-22 18:16 ` Joel Brobecker
2008-11-23 21:15 ` Tom Tromey
2008-11-23 23:06 ` Joel Brobecker
2008-11-24 1:41 ` Tom Tromey
2008-11-24 2:30 ` Joel Brobecker [this message]
2008-11-24 3:09 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081122182132.GH4318@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox