Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFA: fix address in call to val_print
Date: Mon, 24 Nov 2008 03:09:00 -0000	[thread overview]
Message-ID: <m3tz9z8va1.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20081122182132.GH4318@adacore.com> (Joel Brobecker's message of "Sat\, 22 Nov 2008 10\:21\:32 -0800")

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

Joel> If it depends on some functionality that's still only in the Archer
Joel> repo, then let's defer that until that piece of functionaly is in
Joel> the FSF repo.

Yeah, the only case I know of depends on other code from the python
branch which is not yet in gdb.  Specifically, when pretty-printing we
reconstruct a "struct value" from the arguments to val_print; in this
case the address being 0 causes problems later when trying to take the
address of an object -- gdb complains that it does not have an
address.

Joel> In the meantime, the code patch is OK to go in (unless you'd prefer
Joel> to hold off on it, but I would imagine that the fewer local changes
Joel> in the Archer repo, the better).

Ok, I will check it in.  Thanks for clarifying this.

And yeah, I'm trying to flush out the various independent bug fixes
and changes from the python branch.  I am trying to set the stage to
submit the pretty-printing feature.

Tom


      reply	other threads:[~2008-11-22 18:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-21 16:22 Tom Tromey
2008-11-22 18:16 ` Joel Brobecker
2008-11-23 21:15   ` Tom Tromey
2008-11-23 23:06     ` Joel Brobecker
2008-11-24  1:41       ` Tom Tromey
2008-11-24  2:30         ` Joel Brobecker
2008-11-24  3:09           ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3tz9z8va1.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox