Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org, Michael Snyder <msnyder@vmware.com>
Subject: Re: [commit] fix for "info threads" printing multiple headers
Date: Tue, 22 Feb 2011 17:45:00 -0000	[thread overview]
Message-ID: <m3vd0cm0n2.fsf@fleche.redhat.com> (raw)
In-Reply-To: <201102220851.20252.pedro@codesourcery.com> (Pedro Alves's	message of "Tue, 22 Feb 2011 08:51:19 +0000")

>>>>> "Pedro" == Pedro Alves <pedro@codesourcery.com> writes:

Pedro> Thanks!  A few comments below.  If you don't want to
Pedro> fix these, I'll try to find a bit later on myself.

Pedro> - get_number_or_range mantains an internal state machine
Pedro> using static variables.  I think that as long as you
Pedro> always pass in the same list string, and the list spec
Pedro> string is correctly formed, you're not hitting stale
Pedro> state inside get_number_or_range.  It'd be nicer
Pedro> if get_number_or_range (or a variant which get_number_or_range
Pedro> would then be implemented on top of) took an additional
Pedro> struct pointer that pointed to a struct that held
Pedro> all the currently static state.

I almost did this when moving stuff to cli-utils, but decided against it
on the basis of least change.

If Michael doesn't want to implement this, I'd be happy to.
Just let me know.

Tom


  parent reply	other threads:[~2011-02-22 17:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-22  1:57 Michael Snyder
2011-02-22  9:17 ` Pedro Alves
2011-02-22 10:04   ` Pedro Alves
2011-02-22 17:45   ` Tom Tromey [this message]
2011-02-22 18:37     ` Michael Snyder
2011-02-22 18:49       ` Pedro Alves
2011-02-22 18:31   ` Michael Snyder
2011-02-22 18:41     ` Pedro Alves
2011-02-22 18:55       ` Michael Snyder
2011-02-22 17:37 ` Tom Tromey
2011-02-22 18:36   ` Michael Snyder
2011-02-22 19:00     ` Tom Tromey
2011-02-22 20:05       ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3vd0cm0n2.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=msnyder@vmware.com \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox