From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19593 invoked by alias); 22 Feb 2011 17:37:22 -0000 Received: (qmail 19585 invoked by uid 22791); 22 Feb 2011 17:37:22 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 Feb 2011 17:37:18 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p1MHb7IW014913 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 22 Feb 2011 12:37:07 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p1MHb7e2009765; Tue, 22 Feb 2011 12:37:07 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p1MHb6eX024983; Tue, 22 Feb 2011 12:37:06 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 102563784EA; Tue, 22 Feb 2011 10:37:06 -0700 (MST) From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org, Michael Snyder Subject: Re: [commit] fix for "info threads" printing multiple headers References: <4D62F7D6.8040705@vmware.com> <201102220851.20252.pedro@codesourcery.com> Date: Tue, 22 Feb 2011 17:45:00 -0000 In-Reply-To: <201102220851.20252.pedro@codesourcery.com> (Pedro Alves's message of "Tue, 22 Feb 2011 08:51:19 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00599.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> Thanks! A few comments below. If you don't want to Pedro> fix these, I'll try to find a bit later on myself. Pedro> - get_number_or_range mantains an internal state machine Pedro> using static variables. I think that as long as you Pedro> always pass in the same list string, and the list spec Pedro> string is correctly formed, you're not hitting stale Pedro> state inside get_number_or_range. It'd be nicer Pedro> if get_number_or_range (or a variant which get_number_or_range Pedro> would then be implemented on top of) took an additional Pedro> struct pointer that pointed to a struct that held Pedro> all the currently static state. I almost did this when moving stuff to cli-utils, but decided against it on the basis of least change. If Michael doesn't want to implement this, I'd be happy to. Just let me know. Tom