From: Michael Snyder <msnyder@vmware.com>
To: Tom Tromey <tromey@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [commit] fix for "info threads" printing multiple headers
Date: Tue, 22 Feb 2011 20:05:00 -0000 [thread overview]
Message-ID: <4D640856.5080804@vmware.com> (raw)
In-Reply-To: <m34o7vnbkg.fsf@fleche.redhat.com>
Tom Tromey wrote:
>>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:
>
> Michael> - if (argc == 1)
> Michael> - thread = atoi (argv[0]);
> Michael> -
> Michael> - print_thread_info (uiout, thread, -1);
> Michael> + print_thread_info (uiout, argv[0], -1);
>
> Tom> This changes the arguments accepted by the MI command.
>
> Tom> Maybe it isn't a big deal; but I thought it was at least worth pointing
> Tom> out. I'm not sure how much argument checking MI does -- by the looks of
> Tom> the pre-patch source, not much.
>
> Michael> Hmmm? My intention was to change only what was passed to
> Michael> print_thread_info. How does it change the syntax of the command?
>
> The command is documented to accept a thread number, but now it also
> accepts a range.
Oooohhh, I hadn't thought of that.
prev parent reply other threads:[~2011-02-22 19:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-22 1:57 Michael Snyder
2011-02-22 9:17 ` Pedro Alves
2011-02-22 10:04 ` Pedro Alves
2011-02-22 17:45 ` Tom Tromey
2011-02-22 18:37 ` Michael Snyder
2011-02-22 18:49 ` Pedro Alves
2011-02-22 18:31 ` Michael Snyder
2011-02-22 18:41 ` Pedro Alves
2011-02-22 18:55 ` Michael Snyder
2011-02-22 17:37 ` Tom Tromey
2011-02-22 18:36 ` Michael Snyder
2011-02-22 19:00 ` Tom Tromey
2011-02-22 20:05 ` Michael Snyder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D640856.5080804@vmware.com \
--to=msnyder@vmware.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox