From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10702 invoked by alias); 22 Feb 2011 19:02:52 -0000 Received: (qmail 10694 invoked by uid 22791); 22 Feb 2011 19:02:52 -0000 X-SWARE-Spam-Status: No, hits=-4.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 Feb 2011 19:02:48 +0000 Received: from mailhost3.vmware.com (mailhost3.vmware.com [10.16.27.45]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 0F0914A009; Tue, 22 Feb 2011 11:02:47 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost3.vmware.com (Postfix) with ESMTP id 054A4CD96A; Tue, 22 Feb 2011 11:02:47 -0800 (PST) Message-ID: <4D640856.5080804@vmware.com> Date: Tue, 22 Feb 2011 20:05:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101201) MIME-Version: 1.0 To: Tom Tromey CC: "gdb-patches@sourceware.org" Subject: Re: [commit] fix for "info threads" printing multiple headers References: <4D62F7D6.8040705@vmware.com> <4D6401DF.5030004@vmware.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00623.txt.bz2 Tom Tromey wrote: >>>>>> "Michael" == Michael Snyder writes: > > Michael> - if (argc == 1) > Michael> - thread = atoi (argv[0]); > Michael> - > Michael> - print_thread_info (uiout, thread, -1); > Michael> + print_thread_info (uiout, argv[0], -1); > > Tom> This changes the arguments accepted by the MI command. > > Tom> Maybe it isn't a big deal; but I thought it was at least worth pointing > Tom> out. I'm not sure how much argument checking MI does -- by the looks of > Tom> the pre-patch source, not much. > > Michael> Hmmm? My intention was to change only what was passed to > Michael> print_thread_info. How does it change the syntax of the command? > > The command is documented to accept a thread number, but now it also > accepts a range. Oooohhh, I hadn't thought of that.