Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Michael Snyder <msnyder@vmware.com>
Subject: Re: [commit] fix for "info threads" printing multiple headers
Date: Tue, 22 Feb 2011 18:41:00 -0000	[thread overview]
Message-ID: <201102221837.24204.pedro@codesourcery.com> (raw)
In-Reply-To: <4D63FF97.7070903@vmware.com>

On Tuesday 22 February 2011 18:25:27, Michael Snyder wrote:
> Pedro Alves wrote:
>
> > Examples of not handling the special zero:
> > 
> > (gdb) info threads a 1
> >   Id   Target Id         Frame 
> > * 1    Thread 0x7ffff7fd6700 (LWP 13769) "threads" 0x00007ffff7bc7285 in pthread_join () from /lib/libpthread.so.0
> > (gdb)
> > 
> > (gdb) info threads a-1
> > No threads match 'a-1'.
> > 
> > (gdb) info threads a -1
> >   Id   Target Id         Frame 
> > * 1    Thread 0x7ffff7fd6700 (LWP 13769) "threads" 0x00007ffff7bc7285 in pthread_join () from /lib/libpthread.so.0
> > (gdb) 
> > 
> > The last one only "works" by accident due to the extra space.
> 
> 
> OK, test for zero added, how's this?

Looks good.

I was hoping for turning the above into testcases,
making sure they fail.  Can I trick you into
doing it?  "No" is fine.  :-)

-- 
Pedro Alves


  reply	other threads:[~2011-02-22 18:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-22  1:57 Michael Snyder
2011-02-22  9:17 ` Pedro Alves
2011-02-22 10:04   ` Pedro Alves
2011-02-22 17:45   ` Tom Tromey
2011-02-22 18:37     ` Michael Snyder
2011-02-22 18:49       ` Pedro Alves
2011-02-22 18:31   ` Michael Snyder
2011-02-22 18:41     ` Pedro Alves [this message]
2011-02-22 18:55       ` Michael Snyder
2011-02-22 17:37 ` Tom Tromey
2011-02-22 18:36   ` Michael Snyder
2011-02-22 19:00     ` Tom Tromey
2011-02-22 20:05       ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201102221837.24204.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=msnyder@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox