From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 707 invoked by alias); 22 Feb 2011 18:37:39 -0000 Received: (qmail 697 invoked by uid 22791); 22 Feb 2011 18:37:38 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 Feb 2011 18:37:33 +0000 Received: (qmail 7472 invoked from network); 22 Feb 2011 18:37:31 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 22 Feb 2011 18:37:31 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [commit] fix for "info threads" printing multiple headers Date: Tue, 22 Feb 2011 18:41:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.35-25-generic; KDE/4.6.0; x86_64; ; ) Cc: Michael Snyder References: <4D62F7D6.8040705@vmware.com> <201102220851.20252.pedro@codesourcery.com> <4D63FF97.7070903@vmware.com> In-Reply-To: <4D63FF97.7070903@vmware.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201102221837.24204.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00615.txt.bz2 On Tuesday 22 February 2011 18:25:27, Michael Snyder wrote: > Pedro Alves wrote: > > > Examples of not handling the special zero: > > > > (gdb) info threads a 1 > > Id Target Id Frame > > * 1 Thread 0x7ffff7fd6700 (LWP 13769) "threads" 0x00007ffff7bc7285 in pthread_join () from /lib/libpthread.so.0 > > (gdb) > > > > (gdb) info threads a-1 > > No threads match 'a-1'. > > > > (gdb) info threads a -1 > > Id Target Id Frame > > * 1 Thread 0x7ffff7fd6700 (LWP 13769) "threads" 0x00007ffff7bc7285 in pthread_join () from /lib/libpthread.so.0 > > (gdb) > > > > The last one only "works" by accident due to the extra space. > > > OK, test for zero added, how's this? Looks good. I was hoping for turning the above into testcases, making sure they fail. Can I trick you into doing it? "No" is fine. :-) -- Pedro Alves