From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: lazily call save_current_space_and_thread
Date: Mon, 07 Mar 2011 19:54:00 -0000 [thread overview]
Message-ID: <m3vczulnj0.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20110305125239.GA31797@host1.jankratochvil.net> (Jan Kratochvil's message of "Sat, 5 Mar 2011 13:52:39 +0100")
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
>> + if (current_space_cleanup == NULL)
>> + current_space_cleanup = save_current_space_and_thread ();
Jan> save_current_space_and_thread - like any make_cleanup derivation -
Jan> may return NULL even for successfully pushed cleanup function. For
Jan> example inside TRY_CATCH, due to its save_cleanups.
In this case I still think it is safe -- but it is silly to rely on that
when a flag is just as easy.
I think I can actually make make_cleanup_restore_current_thread more
efficient. But if not, I will reimplement this with a flag.
Tom
next prev parent reply other threads:[~2011-03-07 19:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-04 19:52 Tom Tromey
2011-03-05 12:52 ` Jan Kratochvil
2011-03-07 19:54 ` Tom Tromey [this message]
2011-03-08 17:14 ` Tom Tromey
2011-03-08 17:16 ` Jan Kratochvil
2011-03-08 17:23 ` Pedro Alves
2011-03-08 17:49 ` Tom Tromey
2011-03-08 17:56 ` Pedro Alves
2011-03-08 18:02 ` Tom Tromey
2011-03-08 18:15 ` Pedro Alves
2011-03-08 18:37 ` Pedro Alves
2011-03-08 20:01 ` Tom Tromey
2011-03-08 23:02 ` Pedro Alves
2011-03-10 20:09 ` Tom Tromey
2011-03-08 19:54 ` Tom Tromey
2011-03-08 19:54 ` Pedro Alves
2011-03-09 14:43 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3vczulnj0.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox