From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@redhat.com>,
Jan Kratochvil <jan.kratochvil@redhat.com>
Subject: Re: RFC: lazily call save_current_space_and_thread
Date: Tue, 08 Mar 2011 17:23:00 -0000 [thread overview]
Message-ID: <201103081715.49038.pedro@codesourcery.com> (raw)
In-Reply-To: <m3bp1limhf.fsf@fleche.redhat.com>
On Tuesday 08 March 2011 16:51:56, Tom Tromey wrote:
> + /* If we naively call get_selected_frame here, then we can
> + end up reading debuginfo for the current frame, even
> + though the user has not selected a frame and we don't
> + actually need the debuginfo at this point. */
> + frame = get_selected_frame_if_set ();
The comment doesn't seem to make much sense as is. I think
that when the user has the prompt, selected_frame is not going
to be NULL, as normal_stop does:
select_frame (get_current_frame ());
I think the case at hand is while we're handling internal
events, before giving the prompt to the user. Is that so?
--
Pedro Alves
next prev parent reply other threads:[~2011-03-08 17:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-04 19:52 Tom Tromey
2011-03-05 12:52 ` Jan Kratochvil
2011-03-07 19:54 ` Tom Tromey
2011-03-08 17:14 ` Tom Tromey
2011-03-08 17:16 ` Jan Kratochvil
2011-03-08 17:23 ` Pedro Alves [this message]
2011-03-08 17:49 ` Tom Tromey
2011-03-08 17:56 ` Pedro Alves
2011-03-08 18:02 ` Tom Tromey
2011-03-08 18:15 ` Pedro Alves
2011-03-08 18:37 ` Pedro Alves
2011-03-08 20:01 ` Tom Tromey
2011-03-08 23:02 ` Pedro Alves
2011-03-10 20:09 ` Tom Tromey
2011-03-08 19:54 ` Tom Tromey
2011-03-08 19:54 ` Pedro Alves
2011-03-09 14:43 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103081715.49038.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox