From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10247 invoked by alias); 8 Mar 2011 17:16:00 -0000 Received: (qmail 10238 invoked by uid 22791); 8 Mar 2011 17:15:58 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 08 Mar 2011 17:15:52 +0000 Received: (qmail 2412 invoked from network); 8 Mar 2011 17:15:50 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 8 Mar 2011 17:15:50 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: RFC: lazily call save_current_space_and_thread Date: Tue, 08 Mar 2011 17:23:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.35-27-generic; KDE/4.6.1; x86_64; ; ) Cc: Tom Tromey , Jan Kratochvil References: In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201103081715.49038.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00544.txt.bz2 On Tuesday 08 March 2011 16:51:56, Tom Tromey wrote: > + /* If we naively call get_selected_frame here, then we can > + end up reading debuginfo for the current frame, even > + though the user has not selected a frame and we don't > + actually need the debuginfo at this point. */ > + frame = get_selected_frame_if_set (); The comment doesn't seem to make much sense as is. I think that when the user has the prompt, selected_frame is not going to be NULL, as normal_stop does: select_frame (get_current_frame ()); I think the case at hand is while we're handling internal events, before giving the prompt to the user. Is that so? -- Pedro Alves