From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14582 invoked by alias); 7 Mar 2011 19:49:00 -0000 Received: (qmail 14573 invoked by uid 22791); 7 Mar 2011 19:49:00 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 07 Mar 2011 19:48:53 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p27Jmqs1031865 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 7 Mar 2011 14:48:52 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p27Jmqi2002865; Mon, 7 Mar 2011 14:48:52 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p27JmpFm014465; Mon, 7 Mar 2011 14:48:51 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 4704D378339; Mon, 7 Mar 2011 12:48:51 -0700 (MST) From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: RFC: lazily call save_current_space_and_thread References: <20110305125239.GA31797@host1.jankratochvil.net> Date: Mon, 07 Mar 2011 19:54:00 -0000 In-Reply-To: <20110305125239.GA31797@host1.jankratochvil.net> (Jan Kratochvil's message of "Sat, 5 Mar 2011 13:52:39 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00488.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: >> + if (current_space_cleanup == NULL) >> + current_space_cleanup = save_current_space_and_thread (); Jan> save_current_space_and_thread - like any make_cleanup derivation - Jan> may return NULL even for successfully pushed cleanup function. For Jan> example inside TRY_CATCH, due to its save_cleanups. In this case I still think it is safe -- but it is silly to rely on that when a flag is just as easy. I think I can actually make make_cleanup_restore_current_thread more efficient. But if not, I will reimplement this with a flag. Tom